-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving a block down forces a re-render #544
Comments
Related: facebook/react#858 And before I found that, I put together a minimal proof-of-concept: https://codepen.io/aduth/pen/QvpxwL |
Looking like this is just how the DOM works: http://stackoverflow.com/a/8318401 |
Actually... it might not be pretty, but we could do some wizardry with the Flexbox |
Yeah moving iframes will always reload them. A way to avoid that is to move stuff around the iframe instead of the iframe itself. E.g. move the prev block down to move up. That flexbox approach is super interesting! |
The re-render happens on the block control bar as well when you move any block down. |
Removed this from the milestone. I still think it would be good to have fixed, and it seems like #563 might fix it. But it is less important than the other items in the milestone. So untracking for now. |
About flexbox re-ordering (a similar W3C note applies also to CSS grids), see: |
So it's a no?
|
Closing as unfixable. |
Moving a block up seems to be great, but moving it down seems to be triggering a re-render of the block content. The YouTube embed is a good example, where moving up is fine, but moving down re-generates the video and toolbar.
The text was updated successfully, but these errors were encountered: