-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patterns: Consider a more streamlined way to convert sync status #53320
Comments
There was a deliberate decision made to remove this feature due to the complications altering a pattern's synced status can cause. Given that, I'm not sure this will be reinstated any time soon given workarounds such as duplicating a synced pattern as an unsynced pattern, or the proposed partially synced patterns which will allow customizations per pattern instance. You can find some history and context on the previous decision in #51920 (comment). |
Yeah, I can definitely see how unsyncing a pattern would be tricky, but I have several friends in this boat with quite a lot of synced patterns that they utilized as reusable blocks. Could you clarify on the "workarounds such as duplicating a synced pattern as an unsynced pattern? |
There are a few ways to do this -- the way you described or duplicating the pattern in the Site Editor > Patterns section before changing sync status there. I am getting feedback though from the FSE Outreach program around this with folks not knowing how to accomplish this when presented with the task. Mind if I update this issue a bit to make it something design might be able to consider? |
When I was chatting with one of the folks affected by this, we tried the Site Editor > Patterns section, but that doesn't allow us to edit the sync status. From what @aaronrobertshaw said, it sounds like that ability was removed intentionally, but maybe I missed something there. |
I definitely recommend reading the linked convo as it goes into great detail around the technical limitations that would be much easier not to restate here: #51920 (comment) I do think this feedback around sync status and changing it is worth adding some nudges around, perhaps in the detail view when hovering over sync status. I'd like to update this issue with some of those ideas but want your permission first :) |
Ah yes, that is the one I read through, I was just a little fuzzy on the details. However, I've never seen or found any ability to change the sync state of a pattern, whether using an FSE theme (Twenty Twenty-Three) or I guess what is called a class theme (Twenty Twenty). The idea of duplicating a pattern and being able to change it to unsynced would be great. However, even that isn't possible at this point. Feel free to share your other ideas here, because I definitely feel like there is room for improvement. |
Thank you for the continued discussion @nosilver4u and @annezazu 🙇
I believe this is correct. There isn't currently an option available to desynchronize a synced source pattern, you can only detach or desynchronize an instance of such a pattern.
My understanding of the current workaround is:
I certainly understand and appreciate that is an unwieldy and unsatisfactory process long term. One possibility to improve things a little is to enhance the duplication process in the Site Editor. Rather than immediately duplicating the existing pattern (including sync status), it would present a modal allowing for adjusting the duplicated pattern's name and sync status. This needs some extra design consideration before we can proceed with it. Any modal introduced for this purpose may also need to be reused to edit other aspects of a pattern. A pragmatic view here is that there might be some other higher-impact issues with patterns that we need to address before this, given there is an existing way to achieve the desired result, as clunky as that might be for now. I'd like to restate, this is definitely something I'd like to see improved and it will be given some time. It may not happen before the next WordPress 6.4 release though. |
I'd also like to clarify that the duplication option in the Site Editor doesn't help any of the folks I know, as we're all using classic themes. I only tested that method to see if one could create an unsynced pattern via the duplicate option. |
I took the liberty of updating this issue, changing the title, adding it to the 6.4 board for design to consider, and now tagging design @WordPress/gutenberg-design for awareness. |
I would +1 @aaronrobertshaw comments that this is really a prioritisation question at this point. I'm not sure you should ever be able to change the sync status of a source (Figma also doesn't do this) but renaming and setting status on duplication seems like an improvement to the current workaround. I'm moving this out of 6.4 but we can reconsider in future releases. |
A new flow for duplicating patterns has been implemented via #54764. When duplicating a pattern, you'll now be presented with a modal allowing customization of the duplicated pattern's name, categories, and sync status. This should make the accepted workaround for not being able to change a pattern's sync status much easier. There is also another PR in the works (#55292) that will allow pattern duplication via a command when viewing or editing a pattern in the site editor. I'd then like to propose we close this issue as resolved. What do you all think? |
That's great progress, but doesn't resolve the issue for all the folks using classic themes (without a site editor). |
That's correct. Thanks for flagging that @nosilver4u 👍 Unfortunately, access to the site editor's patterns page for classic themes wasn't able to make it into 6.4 however it is slated for 6.5. You can find further info in #52150 (comment) For classic themes, that leaves only the original workaround of copying blocks, creating a new pattern with the different sync status, and pasting the blocks. The suggested nudge would only be available in the site editor as well. As there is a dedicated issue for classic theme access to the patterns page, a core PR in progress for that, the new duplication flow implemented for the site editor, and an existing workaround (copying blocks and creating new patterns). My vote would still be to close this issue and focus further on the classic theme access. I do appreciate the current functionality isn't the perfect outcome for classic themes but with #52150 and WordPress/wordpress-develop#5201 it will be fixed and not slip through the cracks. @annezazu any suggestions on the best path forward? |
I agree with you. Thanks for acting quickly here and reducing the steps needed to make this happen.
Agreed. I am bummed this didn't make it into 6.4 but adding anything now doesn't make much sense when this is coming up in 6.5. @t-hamano as another great example of why the work you've been doing matters so much! |
I was wondering how to convert an unsynced pattern into a synced one when I came across this conversation. Good to see this discussion and gain an understanding of the complications. I like the idea of the duplication modal and its "nudge". Thanks for all you do everyone! |
What problem does this address?
Some folks have used Reusable Blocks as Patterns by inserting the Reusable Block into a new post/page and detaching it. This functionality is now provided by unsynced Patterns, yet there is no easy way to convert a synced pattern into an unsynced pattern. The process currently is to do the following:
What is your proposed solution?
Enhance the duplication process:
Consider adding in interface nudges:
Other brilliant design ideas!
The text was updated successfully, but these errors were encountered: