Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block] Image - Resized images maintain a fixed height on small screens, distorting image or adding margins #52739

Closed
cuemarie opened this issue Jul 18, 2023 · 5 comments · Fixed by #53274
Assignees
Labels
[Block] Image Affects the Image Block [Type] Bug An existing feature does not function as intended

Comments

@cuemarie
Copy link

Description

When an image block is resized and the user does not choose a scaling behavior, the image is stretched (compressed) on mobile devices, retaining it's original height while reducing it's width to fit the screen.

If the user chooses the Scale option to contain the image size, there are large white margins added above and below the image on small devices in order to retain the same height.

Step-by-step reproduction instructions

  1. Insert an image into a post
  2. Resize the image to a smaller size, but do not select a scaling option
  3. View the site using responsive tools and observe the image respond by only reducing width
  4. Return to the editor and select Contain under SCALE
  5. Refresh the site, and now observe the margins added to top and bottom of the image, again retaining the height of the image

Screenshots, screen recording, code snippet

Screen.Capture.on.2023-07-18.at.09-45-47.mp4

No Scale Set
Markup on 2023-07-18 at 10:01:45

"Contain" Scale Set
Markup on 2023-07-18 at 09:56:13

Environment info

  • WordPress 6.2.2
  • Replicated in Gutenberg 16.2.1, 16.2.0, 16.1.2, and with Gutenberg deactivated.
  • Theme used in test: TT3

Originally reported here: Automattic/wp-calypso#79533

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@cuemarie
Copy link
Author

Workaround

In the editor, clear out the Height selection and it will default to Auto and remove the scaling feature. This will correct the issue:

Editor
Markup on 2023-07-18 at 10:04:49

Live Site
Markup on 2023-07-18 at 10:05:11

@sgomes
Copy link
Contributor

sgomes commented Jul 19, 2023

Trying this on a different example, the element had the following styles:

{
    width: 545px;
    height: 472px;
}

But Gutenberg also adds the following:

.wp-block-image img {
    box-sizing: border-box;
    height: auto;
    max-width: 100%;
    vertical-align: bottom;
}

This means that when max-width kicks in, the height is no longer proportional, because it’s using the 472px fixed value, which has precedence over the auto because it's in an element style attribute.

@sgomes
Copy link
Contributor

sgomes commented Jul 19, 2023

The only solution I see here (other than the contain approach) is to keep height as auto in the element styles. So instead of:

{
    width: 545px;
    height: 472px;
}

the element styles should be:

{
    width: 545px;
    height: auto;
    aspect-ratio: 545 / 472;
}

This will account for the use-case where the aspect ratio is intentionally changed (i.e. when the user intentionally stretched the image in the editor), and will preserve that aspect ratio regardless of whether the preferred width or the max width gets used.

@foosantos foosantos added [Type] Bug An existing feature does not function as intended [Block] Image Affects the Image Block labels Jul 19, 2023
@annezazu annezazu added this to Polish Jul 25, 2023
@annezazu annezazu moved this to Needs development in Polish Jul 25, 2023
@annezazu
Copy link
Contributor

@ajlende I see you're working on some image block fixes. Mind taking a look here?

@ajlende
Copy link
Contributor

ajlende commented Jul 26, 2023

Thanks for the ping. This is another side-effect of #52286 it seems. I'll try to take a look this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment