Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library: Snackbar notices are not shown when deleting a pattern #52003

Closed
talldan opened this issue Jun 28, 2023 · 1 comment
Closed

Library: Snackbar notices are not shown when deleting a pattern #52003

talldan opened this issue Jun 28, 2023 · 1 comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented Jun 28, 2023

Description

Snackbar notices don't seem to be working in the Library.

There is code to trigger a notification, for example when deleting a pattern, but the notice doesn't appear in the UI.

Step-by-step reproduction instructions

  1. Open the site editor
  2. Open the library from the navigation menu.
  3. Open the 'Custom patterns' from the navigation menu
  4. Using the 'Actions' dropdown or the delete shortcut, try deleting a pattern

Expected: The pattern is deleted, a snackbar notice is shown confirming, and the deletion is announced to screenreaders.
Actual: The pattern is deleted, there's no snackbar or announcement

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced labels Jun 28, 2023
@talldan talldan mentioned this issue Jun 28, 2023
Closed
92 tasks
@kevin940726 kevin940726 mentioned this issue Jun 28, 2023
Merged
@talldan
Copy link
Contributor Author

talldan commented Jun 28, 2023

Fixed by #52021

@talldan talldan closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@talldan