LinkControl: Surface contextual suggestions

[richtabor]

Part of #50891

Anytime you apply a link initial suggestions isInitialSuggestions should be available. Navigation Link block variations already do this; the behavior should be the default across any LinkControl implementation.

Default suggestions: Pages are the default suggestions, though if a suggestionsQuery is passed, those defined types use the suggested types instead—i.e. Category Link block uses categories as the default suggestions.

Search suggestions (results): Searching returns all content types, unless there is a suggestionsQuery passed. In that case, suggestions should be based on the suggestionsQuery type—i.e. Category Link block results are all categories.

Tasks

• Suggestions are always surfaced in LinkControl (default to pages only).
• Search suggestions (i.e. results) return all content, unless there are types from suggestionsQuery
• Remove the "Recently updated" search results label.

Visual

Before	After

[getdave]

Remove the "Recently updated" search results label.

To confirm do you expect that visual users will have sufficient context to know that these are "recent". I think that's a fair assumption. However, for non-visual users we might like to retain this cue in a visually hidden way in order that they can better perceive the interface. Would you agree?

[richtabor]

However, for non-visual users we might like to retain this cue in a visually hidden way in order that they can better perceive the interface.

Yea, this should do here: #50977

[getdave]

Questions

• should suggestions always be showing on link creation or on editing as well?
• should we apply this conditionally only to rich text links. This would avoid backwards compatibility issues with the UI/UX for consumers of the <LinkControl>. We have a prop showInitialSuggestions which governs this already.

[richtabor]

Only on link creation I think. When you’re editing a link, you should see matched results (already there today).

[richtabor]

@draganescu what do you think about rolling out the suggestions work to the general link editing?

Ideally, anytime you add a link you should have suggestions. This below would have suggestions:

Related to #54622 (comment).

[draganescu]

I thought about it as well. The problem is what to suggest? Pages? When linking random bits of text are the usual links more to external contents? Would suggestions that add clutter?

[richtabor]

I thought about it as well. The problem is what to suggest? Pages?

Yes. What about pages for page post types, and posts for post post types perhaps?

When linking random bits of text are the usual links more to external contents? Would suggestions that add clutter?

I don't think they'll clutter. There's room as-is to fill in without adding much cognitive load.

[mikeicode]

Suggestion:

When adding pages to a navigation block using Page Link, a few page suggestions pop up. However, these options don't update once I add the page to the menu. Ideally, once I add the "services" page to the menu, it wouldn't suggest adding that page again.

In this example, there is an "about" page on the site that I need to add to the menu; ideally, that would be one of the suggestions.

[richtabor]

However, these options don't update once I add the page to the menu.

Makes sense to me, thanks for sharing this.

[draganescu]

I think we should update the PR description and mockups to include this tiny spec of removing what is already added. It could be easily achieved with an exclude list coming from a flattening of the navigation tree.

[getdave]

@richtabor @draganescu I'm a bit lost as to the status of this one. I know Andrei did some work here but do we still want to do the tasks in the Issue description?

[getdave]

Search suggestions (i.e. results) return all content, unless there are types from suggestionsQuery

I think we do this already right? If so we can ✅ the relevant box in the description.

[draganescu]

This doesn't currently work

The idea is that we show suggestions (defaulting to pages) as soon as the input for link appears.

[getdave]

Will be partially solved by #57743.

[richtabor]

Will be partially solved by #57743.

Let's close this now. Good work team.