Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video block: URL edit button is inaccessible #50488

Closed
EricDu opened this issue May 9, 2023 · 1 comment
Closed

Video block: URL edit button is inaccessible #50488

EricDu opened this issue May 9, 2023 · 1 comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended

Comments

@EricDu
Copy link

EricDu commented May 9, 2023

Description

Reported on https://core.trac.wordpress.org/ticket/58280

When replacing a video, the "Edit URL" button is out of sight and requires horizontal scrolling to find it.

Step-by-step reproduction instructions

  1. Add a video block. Input vide URL.
  2. Select "Replace".
  3. Video URL is outside the modal. You have to scroll horizontally to find it.

Solution would be to add a max-width to block-editor-link-control__search-item-header (hoping that doesn't break anything else).

Screenshots, screen recording, code snippet

No response

Environment info

WordPress 6.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@andrewserong andrewserong added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label May 10, 2023
@andrewserong
Copy link
Contributor

Thank you for opening this issue! From a little big of digging, it appears that it's already been fixed in the Gutenberg plugin (in #47949, which landed in GB version 15.3), and the fix will be rolled out into WordPress core in WordPress 6.3.

Here's how that component is looking in my test environment:

image

It looks like the wrapper for block-editor-link-control__search-item-info was missing a max-width, so the text wasn't being truncated. #47949 added in the missing max-width.

I'll close out this issue now since the fix is in the plugin. Feel free to re-open if you can reproduce the issue with the current version of the Gutenberg plugin active.

@andrewserong andrewserong added the [Type] Bug An existing feature does not function as intended label May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants