Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Parts and path towards "library" management #50397

Closed
2 of 3 tasks
Tracked by #33094
mtias opened this issue May 5, 2023 · 9 comments
Closed
2 of 3 tasks
Tracked by #33094

Template Parts and path towards "library" management #50397

mtias opened this issue May 5, 2023 · 9 comments
Labels
[Block] Template Part Affects the Template Parts Block Needs Design Feedback Needs general design feedback.

Comments

@mtias
Copy link
Member

mtias commented May 5, 2023

Milestone 1

  • Use two rhomboid icon symbol for template parts menu.

Milestone 2

@mtias mtias mentioned this issue May 5, 2023
57 tasks
@mtias mtias changed the title Library Template Parts and path towards "library" management May 5, 2023
@gziolo gziolo added the [Block] Template Part Affects the Template Parts Block label May 6, 2023
@SaxonF
Copy link
Contributor

SaxonF commented May 8, 2023

Adding a potential pathway here.

We've put far more emphasis on patterns as of late and will continue to do so. The site editor currently doesn't reflect these efforts. This project aims to set the stage for block unification by introducing the concept of a library which is a dedicated space for all the building blocks of your site.

For this bit of work we can simply rename the Template Parts menu item to Library and introducing category grouping to the list page. This includes Headers, Footers, and any other template parts available.

This new "Library" space is a natural fit for when pattern management becomes a thing.

6.3-library.mp4
  • The top level template parts menu item is renamed to library using rhomboid icon initially
  • The library panel contains a menu listing all template part areas. Headers and Footers use their corresponding icon while General + others use template-part. Whether these need to drilldowns or just panel sections is worth considering.
  • There is an additional "Reusable blocks" menu item that links off the existing re-usable blocks management screen in a new tab
  • Much like the existing template parts screen the + button triggers the new template part modal
  • Clicking an area/category takes you to a full list of template parts for that area
  • Within each area, the + button automatically sets the template area on part creation
  • Quick links section at the bottom contains "Manage all template parts" which opens the existing template parts page.

@jasmussen
Copy link
Contributor

Noting #50028 as related to this one.

@annezazu annezazu added the Needs Design Needs design efforts. label May 15, 2023
@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization May 15, 2023
@jasmussen jasmussen moved this from Needs design, or refresh to Needs feedback in 6.3 Design May 16, 2023
@jasmussen jasmussen added Needs Design Feedback Needs general design feedback. and removed Needs Design Needs design efforts. labels May 16, 2023
@jasmussen
Copy link
Contributor

@SaxonF not urgent, but per recent designs (#50379 (comment) and #50392 (comment) come to mind), would you be able to update your video, or share screenshots instead, with the latest sidebar design? I think we can update this issue and mark it ready for dev with that.

@briceduclos
Copy link

Is there a Figma file of the UI available on the WordPress.org Team?

@annezazu
Copy link
Contributor

Noting that as we explore this Library concept, it would be advantageous to explore how to show the relationship between template parts and templates: #42482

@jameskoster
Copy link
Contributor

Agreed. It doesn't even need to be granular to begin with (though that would be nice). Just marking the items that are actively in use would be helpful. It probably requires a dedicated design effort though, to get the placement right.

Anyway here are some updates to Saxon's earlier visuals, taking into account the latest work around other panels:

Library

Instead of drilldowns for each type, I lean slightly towards a single list for a couple of reasons:

  • Sites do not generally have that many template parts, so clicks are reduced.
  • It allows the reuse of the browse/manage toggle that has been proposed for Templates.
  • Doesn't require any hefty modifications to the existing template part management view.
  • It's pretty close to what we currently have on trunk, so involves a bit less work.

The drilldown pattern can be utilised in the future, once all patterns are displayed in the Library and scalability becomes a bigger issue. Of course if I've missed something and the intention is to have that as a part of 6.3, then we should probably use the drilldown straight-away – though it will require some modifications to the management view.

What do y'all think?

@jasmussen
Copy link
Contributor

I like starting simple.

@jameskoster
Copy link
Contributor

If font management is to live in a modal, it could easily be accessed from the Library panel, which feels conceptually appropriate.

We might use the same format as the theme button at the design root:

Screenshot 2023-05-25 at 13 45 37

I also moved Reusable blocks outside of the main list, since they will not appear in the management view.

@mtias
Copy link
Member Author

mtias commented Jun 28, 2023

One last follow up here: #52042

Rest is considered accomplished.

@mtias mtias closed this as completed Jun 28, 2023
@github-project-automation github-project-automation bot moved this from 🎨 Needs design to ✅ Done in Gutenberg Phase 2: Customization Jun 28, 2023
@github-project-automation github-project-automation bot moved this from Needs feedback to Needs dev in 6.3 Design Jun 28, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block Needs Design Feedback Needs general design feedback.
Projects
Status: Done
Status: Done
Development

No branches or pull requests

7 participants