Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ability to find and insert link to Homepage within Link UI within Nav block #50171

Open
getdave opened this issue Apr 28, 2023 · 3 comments
Assignees
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Apr 28, 2023

It's quite natural and common for someone to want to link to their site's homepage to their Navigation. Currently if you type "Home" in to the search dialog of the Link UI you won't get a useful result.

Let's update the mechanics of the Link UI so that typing "home" initiates custom behaviour which fetches the details of the current homepage and displays that in the search results as the first item (always).

One the result is selected it should auto-insert the Home link block into the Navigation menu.

Visuals

Screenshot 2023-04-28 at 15 13 55

@getdave getdave added the [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) label Apr 28, 2023
@getdave getdave self-assigned this Apr 28, 2023
@getdave getdave added [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block labels Apr 28, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 20, 2023
@richtabor
Copy link
Member

richtabor commented Sep 20, 2023

Currently if you type "Home" in to the search dialog of the Link UI you won't get a useful result.

You're thinking this will use whatever the front-page of your site is yea? You can get the Home result if its a page titled "Home" currently, which may be enough?

But we don't have the home icon (which I think would be helpful).

EDIT: Ah, I see. This is for navigation, not LinkControl search + insert of the home link. Gotcha.

@richtabor
Copy link
Member

Noting a downside to using the Home link block is that it does not have the same Settings as Page Link does. We should probably make these consistent.

CleanShot 2023-09-20 at 10 27 10 CleanShot 2023-09-20 at 10 26 28

@carolinan
Copy link
Contributor

Can you create a separate issue for the home link settings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants