Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Block: "Add Text over image" should be removed #50025

Open
hanneslsm opened this issue Apr 23, 2023 · 3 comments
Open

Image Block: "Add Text over image" should be removed #50025

hanneslsm opened this issue Apr 23, 2023 · 3 comments
Labels
[Block] Image Affects the Image Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@hanneslsm
Copy link

Description

The "Add Text over image" function in the toolbar of the image block should be removed. It does not add text over the image, it transform the image block to a cover block. This is a different behaviour and logic that does not fit to the other functions at that place.

All the other functions in the toolbar can be selected and deselected.
The "Add Text over image" not so.
This is confusing. Especially because there is also no image block in the cover block. Clients ask me: "Where did my image block go?" because they do not understand that they have transformed it into a cover block and the cover block contains the image (but confusingly not a image block but a paragraph block)

Step-by-step reproduction instructions

  1. Select a image block
  2. Select "add Text over image" in the Tool bar
  3. Be confused where your image block is

Screenshots, screen recording, code snippet

Screen.Recording.2023-04-23.at.22.45.03.mp4

Environment info

  • Wordpress 6.2
  • Gutenberg 15.6.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Thelmachido
Copy link

I see what you mean, instead of removing the option it might be better to describe its function a little bit better.

@Thelmachido Thelmachido added [Block] Image Affects the Image Block [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Apr 25, 2023
@hanneslsm
Copy link
Author

hanneslsm commented Apr 25, 2023

I see what you mean, instead of removing the option it might be better to describe its function a little bit better.

I was thinking about this as well. But the best description I could think of was "Transform to cover block". And then, there is a place for that.

I see where the idea implementing this feature is coming from and I know it's well-intentioned but at the end it only confuses people. So my take is: Let's remove this feature to easily and quickly improve the UX of Gutenberg.

@t-hamano
Copy link
Contributor

I have been trying to find out in what context this feature was added and #28414 seems to be its PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants