Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent placeholder/start states between Group and Columns blocks #49525

Open
richtabor opened this issue Apr 1, 2023 · 3 comments
Open
Labels
[Block] Columns Affects the Columns Block [Block] Group Affects the Group Block Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

We currently have two different looks for similar placeholder states, between the Group and Columns block. Is there a reason we should have two varying states here? If not, we should move these states closer together:

CleanShot 2023-03-31 at 21 11 53

@richtabor richtabor added Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Block] Columns Affects the Columns Block [Block] Group Affects the Group Block labels Apr 1, 2023
@richtabor
Copy link
Member Author

Noted that you also can't drop in blocks to the Group block's placeholder state in the content area.

And we may be able to reduce this back to the simpler "empty" Group block state, by adding these as top-level toolbar controls in some fashion via #49524

@richtabor
Copy link
Member Author

Noted that you also can't drop in blocks to the Group block's placeholder state in the content area.

Actually, you can drop in blocks, there's just no indicator that it's possible (#39064).

@jasmussen
Copy link
Contributor

What do you say we merge these two to be the same? (In the style of the former). Conceptually, the group can be the starting point for a variety of different layouts.

The main challenge is how a columns block behaves differently from, for example, a row block. But this is already an issue given we have the multiple options to create columns, and multiple setup states. Ideally merging the two into one — same state for both blocks — could be a way to explain the differences perhaps.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Block] Group Affects the Group Block Needs Design Feedback Needs general design feedback. Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants