Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate Safari duotone re-render scripts #49170

Closed
ajlende opened this issue Mar 17, 2023 · 0 comments · Fixed by #49232
Closed

Consolidate Safari duotone re-render scripts #49170

ajlende opened this issue Mar 17, 2023 · 0 comments · Fixed by #49232
Assignees
@jeryj
Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Comments

@ajlende
Copy link
Contributor

ajlende commented Mar 17, 2023 •
edited
Loading

Safari renders duotone filters with the SVG filter definition coming after the element that they are filtering. This was fixed with a Safari-specific re-render script hack in #36754. With the changes for consolidating filters in #49103, it is now possible to consolidate these scripts as well and minimize the number of script tags on the page.

See #49103 (comment)
@ajlende ajlende mentioned this issue Mar 17, 2023
Open
14 tasks
@Thelmachido Thelmachido added [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement. labels Mar 20, 2023
@jeryj jeryj mentioned this issue Mar 20, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 20, 2023
@jeryj jeryj mentioned this issue Mar 21, 2023
Merged
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeryj jeryj

Labels
[Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
4 participants
@jeryj @ajlende @priethor @Thelmachido