-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misaligned per-block CSS label #48047
Comments
@richtabor there seems to be a difference between the left padding on the top-level global styles panel and the block-level ones. Is this supposed to be the case? For example, if I set the same padding on the additional block CSS section as on the global styles one, it fixes the alignment issue, but it is more indented than the items above it - but in global styles, they line up as more of a left padding for all:
should I just match the left padding of the other items in the block panel, or does that padding need to be adjusted to match the global styles panel? |
Good point. I'm good with resolving the padding discrepancy between the parent and child panels as well. I don't want to index too much on this, as it'll adapt when we move it closer to the Browse Mode UI — but a small padding tweak to consistently align all the controls would be good. Here's what that'd look like, with the Additional block CSS tweak included as well: |
The reason for the inconsistency is not in the actual button, but the space around it as mentioned above. The lower panel has padding where the top one doesn't. Notice the padding is also inconsistent with the panel for style variations, where margin is used. I suggest choosing one value for padding to apply to all the panels, and removing any extra margins that are now being used on e.g. the quote preview and the style variations panel. |
I have made a start on this here, but still a bit of work to do in terms of making sure everything is the same across all the screens. I am AFK for the next week or so, so happy for someone else to pick this up and finish off, otherwise I will finish it off when I am back. |
I agree. It was moved to the Advanced panel as one of #49428. I am closing this issue. |
The "Additional block CSS" label for the per-block CSS should be aligned with the other contents of the panel (like the global additional CSS control is).
Visual
The text was updated successfully, but these errors were encountered: