Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing "explore all patterns" with the pattern explorer not connected to the pattern directory #47582

Closed
annezazu opened this issue Jan 30, 2023 · 4 comments
Closed

Consider removing "explore all patterns" with the pattern explorer not connected to the pattern directory #47582

annezazu opened this issue Jan 30, 2023 · 4 comments
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

With the explore option not fully in place yet with the pattern directory integration #44611 we should reconsider the "explore all patterns" option as the modal currently just opens the same exact views of patterns. Currently, it actually opens to "no results" if you don't first select a category:

pattern.explorer.mov

What is your proposed solution?

Until the pattern directory integration work is done, consider removing the "explore all patterns" option ake the pattern explorer.
@annezazu annezazu added [Type] Enhancement A suggestion for improvement. [Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Pattern Directory The Pattern Directory, a place to find patterns labels Jan 30, 2023
@annezazu annezazu moved this to 📥 Todo in WordPress 6.2 Editor Tasks Jan 30, 2023
@richtabor
Copy link
Member

I think its fine to leave in; it’s not detracting from the experience and I suspect some folks will miss the modal view.

It's better to just update it later with a proper connection to dotOrg patterns, instead of removing/adding it back.

@richtabor
Copy link
Member

Currently, it actually opens to "no results" if you don't first select a category

This seems something we should fix though. I don't believe this was always the case.

@Mamaduka
Copy link
Member

+1 for keeping to explorer. It provides more real estate for viewing the patterns.

Currently, it actually opens to "no results" if you don't first select a category

I noticed this as well. So let's mark this as a bug or regression.

@richtabor richtabor mentioned this issue Feb 1, 2023
Closed
@ndiego ndiego moved this from 📥 Todo to 🗣️ In discussion, needs decision in WordPress 6.2 Editor Tasks Feb 7, 2023
@richtabor
Copy link
Member

Closing this as the explorer will remain, but get leveled-up with a connection to the Patterns Directory #44611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Inserter The main way to insert blocks using the + button in the editing interface [Feature] Pattern Directory The Pattern Directory, a place to find patterns [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mamaduka @richtabor @annezazu