Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Excerpt: Read more link is always on new line in the editor #47458

Closed
iamtakashi opened this issue Jan 26, 2023 · 9 comments · Fixed by #47772
Closed

Post Excerpt: Read more link is always on new line in the editor #47458

iamtakashi opened this issue Jan 26, 2023 · 9 comments · Fixed by #47772
Assignees
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@iamtakashi
Copy link

Description

Post Excerpt has the option to show the read more link on a new line. You'd expect the read more link would appear inline with the excerpt, but it won't. In the editor, the link is always on a new line regardless of the option.

Screenshot 2023-01-26 at 13 08 36

The option works as expected on the front of the site 👍

Screenshot 2023-01-26 at 13 12 20

Step-by-step reproduction instructions

  1. Go to the editor.
  2. Add a post excerpt block
  3. Turn off the "show link on new line" option

Screenshots, screen recording, code snippet

No response

Environment info

WP v6.1.1.
Gutenberg trunk The issue also occurs without the plugin

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Block] Post Excerpt Affects the Post Excerpt Block [Type] Bug An existing feature does not function as intended [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jan 26, 2023
@carolinan
Copy link
Contributor

I am not able to reproduce this with "empty theme", Twenty Twenty-Three or Twenty Twenty-One.
I think this may be a theme issue?

@carolinan
Copy link
Contributor

Update: Actually I can reproduce it in Twenty Twenty-Three but only when the query loop uses the columns:
when here is not enough space to show the place holder on the same line as the excerpt text.
When switching from columns to lists, the option works.

@iamtakashi
Copy link
Author

Actually I can reproduce it in Twenty Twenty-Three but only when the query loop uses the columns:

Hmm, that's strange. The issue occurs regardless of a columns block for me.

Screenshot 2023-01-30 at 12 51 21

@carolinan
Copy link
Contributor

Is it the same if you disable all other plugins?

In this clip I am using WP 6.2-alpha-55160 with TT3. Gutenberg is not active:

Screen.Recording.2023-01-30.at.14.01.44.mov

@iamtakashi
Copy link
Author

Is it the same if you disable all other plugins?

Yes.

Could you try adding the Query Loop block to the root, choose "start blank", and try one of the options that have an excerpt?

Screenshot 2023-01-30 at 14 17 51

@iamtakashi
Copy link
Author

iamtakashi commented Jan 30, 2023

@carolinan, Ah, I think the option works for you because your test post didn't have any text/excerpt that isn't a common case.

Screenshot 2023-01-30 at 14 22 49

Screenshot 2023-01-30 at 14 24 53

@iamtakashi
Copy link
Author

So, in short, the issue always occurs unless the post/excerpt doesn't have any text.

@iamtakashi
Copy link
Author

The issue is that the closing </p> tag does not currently include the read more link when the "show link on new line" is off.

Screenshot 2023-01-31 at 21 48 32

@carolinan
Copy link
Contributor

I have eventually, 😆 been able to reproduce it. I think you may be right about the cause, lets try to see if we can't make the editor and front markup match better.

@carolinan carolinan self-assigned this Feb 6, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 6, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Excerpt Affects the Post Excerpt Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants