Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav offcanvas set the correct aria-posinset for the appender #47024

Closed
getdave opened this issue Jan 10, 2023 · 0 comments · Fixed by #47047
Closed

Nav offcanvas set the correct aria-posinset for the appender #47024

getdave opened this issue Jan 10, 2023 · 0 comments · Fixed by #47047
Assignees
@talldan
Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@getdave
Copy link
Contributor

getdave commented Jan 10, 2023 •
edited by talldan
Loading

As reported in #46939 (comment) by @talldan:

the appender doesn't have the correct aria-posinset value (it's a minor thing as this isn't announced, but it'd be nice to fix it).
@getdave getdave added [Block] Navigation Affects the Navigation Block [a11y] Labelling labels Jan 10, 2023
@getdave getdave mentioned this issue Jan 10, 2023
Closed
15 tasks
@talldan talldan mentioned this issue Jan 11, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
@scruffian scruffian mentioned this issue Jan 23, 2023
Merged
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
@priethor priethor added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [a11y] Labelling labels Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talldan talldan

Labels
[Block] Navigation Affects the Navigation Block [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Navigation block: Fix some off canvas appender accessibility issues WordPress/gutenberg
3 participants
@getdave @talldan @priethor