-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notice appearance in Browse view #46274
Comments
I don't think we should show these in the browse view ever. Browse view is meant to not be an editor, after all. I recognize this can cause an animation jump as you enter the edit mode and the notice appears, but I'd rather have that than notices in both contexts. |
I agree that the notices shouldn't appear in / attached to the frame, but we do need to display confirmation of certain actions in browse view. I just double-checked and template deletion / reversion already shows a snackbar, so we can probably just remove this green "Template reverted" notice altogether since its duplicative. |
Right, I think snackbars are the answer in browse view. |
This looks a bit awkward. Let's think about how to display notices in this view, or perhaps in-canvas notices in general.
The text was updated successfully, but these errors were encountered: