Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notice appearance in Browse view #46274

Closed
jameskoster opened this issue Dec 2, 2022 · 3 comments · Fixed by #46931
Closed

Notice appearance in Browse view #46274

jameskoster opened this issue Dec 2, 2022 · 3 comments · Fixed by #46931
Assignees
Labels
Needs Dev Ready for, and needs developer efforts

Comments

@jameskoster
Copy link
Contributor

Screenshot 2022-12-02 at 11 42 33

This looks a bit awkward. Let's think about how to display notices in this view, or perhaps in-canvas notices in general.

@jasmussen
Copy link
Contributor

I don't think we should show these in the browse view ever. Browse view is meant to not be an editor, after all. I recognize this can cause an animation jump as you enter the edit mode and the notice appears, but I'd rather have that than notices in both contexts.

@jameskoster
Copy link
Contributor Author

I agree that the notices shouldn't appear in / attached to the frame, but we do need to display confirmation of certain actions in browse view.

I just double-checked and template deletion / reversion already shows a snackbar, so we can probably just remove this green "Template reverted" notice altogether since its duplicative.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Dec 8, 2022
@jasmussen
Copy link
Contributor

Right, I think snackbars are the answer in browse view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants