Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use LinkControl in Navigation Link block controls #46217

Open
georgeh opened this issue Nov 30, 2022 · 1 comment
Open

Use LinkControl in Navigation Link block controls #46217

georgeh opened this issue Nov 30, 2022 · 1 comment
Assignees
@georgeh @getdave
Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@georgeh
Copy link
Contributor

georgeh commented Nov 30, 2022 •
edited
Loading

When editing a Navigation Link block in the sidebar, the URL input:

Image

should use a LinkControl to offer suggestions, similar to the way it appears in the block editor:

Image
@georgeh georgeh self-assigned this Nov 30, 2022
@scruffian scruffian mentioned this issue Dec 1, 2022
Closed
32 tasks
@priethor priethor added [Type] Enhancement A suggestion for improvement. [Block] Navigation Affects the Navigation Block [Block] Navigation Link Affects the Navigation Link Block labels Dec 1, 2022
@getdave
Copy link
Contributor

getdave commented Jan 9, 2023

@georgeh Just to let you know I experimented with this and I have it working. I'll spin up a PR

Screen.Capture.on.2023-01-09.at.11-13-50.mp4

@getdave getdave self-assigned this Jan 9, 2023
@getdave getdave mentioned this issue Jan 9, 2023
Closed
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgeh georgeh

@getdave getdave

Labels
[Block] Navigation Link Affects the Navigation Link Block [Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add Link Control UI to the Nav item block sidebar WordPress/gutenberg
3 participants
@georgeh @getdave @priethor