Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-direct insertion in Nav offcanvas inserter #46203

Closed
getdave opened this issue Nov 30, 2022 · 1 comment · Fixed by #46503
Closed

Handle non-direct insertion in Nav offcanvas inserter #46203

getdave opened this issue Nov 30, 2022 · 1 comment · Fixed by #46503
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Design Needs design efforts. [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended

Comments

@getdave
Copy link
Contributor

getdave commented Nov 30, 2022

In #46013 we added an inserter to the Nav offcanvas sidebar.

This works reasonably well when core/navigation-link blocks are auto-inserted which is the default behaviour of the Nav block (see this research).

However if you do the following you will get a different experience:

  • use offcanvas inserter
  • don't type a link into the Link UI
  • click on one of the "Transforms" shown at the bottom of the Link UI
  • see block inserted
  • click inserter in offcanvas again
  • see a full inserter with all the blocks that can be inserted into a Nav block

Again this is due to the behaviour I have previously detailed.

I'd like to know how we'd prefer to handle this situation in the offcanvas. Some design input would really help. Maybe @SaxonF can help here?

@getdave getdave added [Block] Navigation Affects the Navigation Block Needs Design Needs design efforts. labels Nov 30, 2022
@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Priority] High Used to indicate top priority items that need quick attention labels Dec 12, 2022
@getdave getdave self-assigned this Dec 13, 2022
@getdave
Copy link
Contributor Author

getdave commented Dec 13, 2022

I will take this one as I've done the ground work already.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 13, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Needs design efforts. [Priority] High Used to indicate top priority items that need quick attention [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants