Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid browser paint in the editor #46199

Closed
corentin-gautier opened this issue Nov 30, 2022 · 6 comments
Closed

Avoid browser paint in the editor #46199

corentin-gautier opened this issue Nov 30, 2022 · 6 comments
Labels
[Type] Performance Related to performance efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@corentin-gautier
Copy link
Contributor

corentin-gautier commented Nov 30, 2022

Description

This issue tracks the various PR I have open around avoiding browser paint in the editor as requested by @ciampo in #45545 (review):

There are still paint issues that do not have a PR right now, they are related to the fact that the scroll areas are set to overflow: auto;, but setting overflow to scroll breaks the full site editor. Someone with a deeper knowledge of this area might find the solution.

EDIT : This PR should fix the issue with the scrollbars :

@skorasaurus skorasaurus added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Type] Performance Related to performance efforts labels Nov 30, 2022
@ciampo
Copy link
Contributor

ciampo commented Dec 2, 2022

Hey @corentin-gautier , thank you for opening those PRs!

Just wanted to let you know that I won't be around to continue reviewing those PRs in the next weeks, but I've made sure to add other folks as reviewers — so please feel free to ping them in case the reviews go stale without me

@corentin-gautier
Copy link
Contributor Author

Hi @ciampo, I have open a new PR regarding the scroll areas issues :

could you take a look at it or assign someone with knowledge of this area ? This would help close this issue 🙂

@corentin-gautier
Copy link
Contributor Author

#46465 was fixed by #48794

@corentin-gautier
Copy link
Contributor Author

Except for #22822 which might need further improvements, I think this issue can be closed @ciampo

@corentin-gautier
Copy link
Contributor Author

I have also open this issue regarding js perfs #47619

@ciampo
Copy link
Contributor

ciampo commented Mar 21, 2023

Agreed, we can close this issue since it was mostly around paint performance. We can treat input lag and overall bundle size separately.

Thank you for your great work so far!

@ciampo ciampo closed this as completed Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Performance Related to performance efforts [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

3 participants