Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ColorPalette doesn't respect clearable prop value in WP 6.1.1 #45793

Closed
maurisrx opened this issue Nov 16, 2022 · 1 comment
Closed

ColorPalette doesn't respect clearable prop value in WP 6.1.1 #45793

maurisrx opened this issue Nov 16, 2022 · 1 comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@maurisrx
Copy link

Description

In WP 6.1.1, whether the clearable prop is set to true or false the clear button doesn't appear below the color placeholder like it used to until WP 6.1.

Step-by-step reproduction instructions

This code should generate the problematic component:

 <ColorPalette
    colors={ [] }
    value={ '' }
    onChange={ }
    clearable={ true }
/>

Screenshots, screen recording, code snippet

In WP 6.1:
https://monosnap.com/file/XThzj4mvmUqKW1ePK0dRqwB6zIYKcj

In WP 6.1.1:
https://monosnap.com/file/GbuwHUb4vSg4Lx48cRxsDkJwGYxVKl

Environment info

  • WordPress 6.1.1
  • Theme: Twenty Twenty-Three

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Mamaduka Mamaduka added Needs Testing Needs further testing to be confirmed. [Package] Components /packages/components labels Nov 17, 2022
@Mamaduka Mamaduka added [Type] Bug An existing feature does not function as intended and removed Needs Testing Needs further testing to be confirmed. labels Dec 6, 2022
@Mamaduka
Copy link
Member

Mamaduka commented Dec 6, 2022

The issue was fixed via #46001.

@Mamaduka Mamaduka closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants