Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "Open in new window" link option #4571

Closed
ellatrix opened this issue Jan 18, 2018 · 3 comments
Closed

Remove "Open in new window" link option #4571

ellatrix opened this issue Jan 18, 2018 · 3 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@ellatrix
Copy link
Member

ellatrix commented Jan 18, 2018

This was added in #2204 (issue), #2628 (PR).

It was hidden in WordPress 4.5, see https://make.wordpress.org/core/2016/03/28/the-editor-in-wordpress-4-5/#comment-29560.

Adding the target="_blank" attribute is considered bad practice for post/articles. Unless you're making a web app where this behaviour can be crucial, the use of it should be discouraged so that the user/reader of your site can chose what to do for themselves. I personally hate using sites that add this to their links so you'll stay on their site longer or come back to it. On mobile devices this can be even more frustrating. It breaks the history of a tab.

We shouldn't easily allow hijacking default link behaviour with a simple toggle. Changing default behaviour should be well thought out, and this UI does not encourage that.

Interesting article: https://css-tricks.com/use-target_blank/

Conclusion: when it is a good reason to use target="_blank", it is either not about links in posts/articles on sites (but web apps of some kind) or you're dealing with a really special site where it would be better to filter all links form the post content. There seems to be absolutely no reason to have UI in WordPress for it, and if you really, really, really want to add the attribute, people are free to edit the HTML or install a plugin for it.

Some other interesting links from https://make.wordpress.org/core/2016/03/28/the-editor-in-wordpress-4-5/#comment-29566:

@ellatrix ellatrix added Design [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Jan 18, 2018
@youknowriad
Copy link
Contributor

related #4450

@karmatosed
Copy link
Member

I would +1 to remove it.

@braders
Copy link

braders commented Jan 19, 2018

Also related #4499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

4 participants