Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover block within cover block text color not working properly #45560

Open
bradhogan opened this issue Nov 4, 2022 · 1 comment
Open

Cover block within cover block text color not working properly #45560

bradhogan opened this issue Nov 4, 2022 · 1 comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@bradhogan
Copy link

bradhogan commented Nov 4, 2022

Description

Inner cover block does not change from is-light to is-dark-theme it appears only the parent cover block changes.

Step-by-step reproduction instructions

  1. Add cover block
  2. Add text to cover block
  3. Add cover block within the cover block
  4. Add text to the inner cover block
  5. Change the opacity of the background for the parent cover and notice how text changes
  6. Change the opacity of the background for the inner cover block and notice the text does not change (this is the issue)

Screenshots, screen recording, code snippet

Quick video > https://soapbox.wistia.com/videos/2FoAHr2Su8

Environment info

wp 6.1
gutenberg 14.4.0
chrome 107.0.5304.87
macos 12.3.1

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@Azragh
Copy link

Azragh commented Nov 7, 2022

In my opinion, the class "is-light" is generally quite opinion-based and does not work properly even on the first level. Just because a background has less than 60% opacity, it is not necessarily "light" (screenshot row 1). The first two covers have a gradient background, for which white would be the better choice. The other two have a solid colour - the 3rd has a light grey at 90% opacity, the 4th a black at 50%.

In addition, you can also place groups with their own background colours or, as in Bradley's case, additional covers in a cover (screenshot row 2).

Since in most cases (at least in my designs) the background is darkened, I simply set the cover colour to white and overwrote the class "is-light" with white as well. If, exceptionally, a "real" light background is used, I change it manually.

I would also like to have a better solution here, but with only a query of the overlay opacity this seems impossible.

image

@carolinan carolinan added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Nov 9, 2022
@jordesign jordesign added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants