Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ColorPalette: review colord support when using CSS variables #44904

Closed
ciampo opened this issue Oct 12, 2022 · 2 comments
Closed

ColorPalette: review colord support when using CSS variables #44904

ciampo opened this issue Oct 12, 2022 · 2 comments
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@ciampo
Copy link
Contributor

ciampo commented Oct 12, 2022 •
edited
Loading

From the recent discoveries while working on #44668 I also realized that colord will silently fail while parsing CSS variables and fallback to #000000, which means that all the checks / features based on colord are not really working for CSS variables. We should investigate this separately (cc @mirka @chad1008 )

Originally posted by @ciampo in #44632 (comment)
@ciampo ciampo added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Oct 12, 2022
@ciampo ciampo mentioned this issue Oct 12, 2022
Merged
@mirka
Copy link
Member

mirka commented Oct 12, 2022

Related: #41459

@ciampo ciampo mentioned this issue Jan 2, 2023
Closed
@t-hamano t-hamano mentioned this issue Jan 16, 2023
Merged
@ciampo
Copy link
Contributor Author

ciampo commented Jan 25, 2023

With #47181 merged, and #41459 tracking the contrast check bug, I think we treat this issue as a duplicate and close it.

@ciampo ciampo closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirka @ciampo