Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double clicking on a pattern in zoomed out view should go into focus mode #44710

Closed
Tracked by #50739 ...
mtias opened this issue Oct 5, 2022 · 6 comments
Closed
Tracked by #50739 ...
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@mtias
Copy link
Member

mtias commented Oct 5, 2022

On the zoomed out view, double clicking on a pattern should probably get you into the focused template part mode to edit.

@mtias mtias added [Type] Enhancement A suggestion for improvement. [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. labels Oct 5, 2022
@mtias mtias mentioned this issue May 18, 2023
42 tasks
@draganescu
Copy link
Contributor

@richtabor @jeryj any ideas on how this can work with the keyboard? Should we have a focus button in the new toolbar (the one that will exist vertically in zoom out)?

@jeryj
Copy link
Contributor

jeryj commented Apr 12, 2024

Should we have a focus button

I'd think either an edit button or make the current pattern a tabstop on the page an aria-labelled edit pattern button. Or both. In general, the UX is better when there's a visible and labelled button, so a dedicated edit button on the toolbar will likely make it easier for everyone to understand.

@richtabor
Copy link
Member

It'll be a delicate balance navigating in and out of zoom out, without focus mode in there as well. I think as we explore interactions to flow between those views, we may find ways to go "deeper" another level, focusing on a specific pattern. But I'd consider that a secondary effort.

That saying, if we can select template parts in zoom out, we can just use the existing "Edit" button, we already have (for template parts):

CleanShot 2024-04-12 at 16 34 07

@draganescu
Copy link
Contributor

we can just use the existing "Edit" button, we already have (for template parts):

Will this button be in the incoming vertical toolbar to be tried (as the original assembler mockup shows)?

@draganescu
Copy link
Contributor

@richtabor this will only work for partially / synced patterns as the others don't have their id saved so there is nothing to focus? Would having this in - out UX available for parts of the layout and not for others be nice?

@mtias
Copy link
Member Author

mtias commented Sep 29, 2024

I think we don't want to do this anymore, and instead double clicking zooms back in. I think it might still be good to provide a way to edit in focus mode, but it might be in addition to zooming in.

@mtias mtias closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants