Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Flaky Test] should allow a block with styles to be converted to a reusable block #44332

Closed
github-actions bot opened this issue Sep 21, 2022 · 0 comments · Fixed by #44350
Closed

[Flaky Test] should allow a block with styles to be converted to a reusable block #44332

github-actions bot opened this issue Sep 21, 2022 · 0 comments · Fixed by #44350
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented Sep 21, 2022 •
edited
Loading

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should allow a block with styles to be converted to a reusable block

Test path

specs/editor/various/pattern-blocks.test.js

Errors

[2022-09-21T14:58:47.613Z] Test passed after 2 failed attempts on experiment/navigation-block-with-directives.
[2022-09-21T18:55:40.978Z] Test passed after 2 failed attempts on trunk.
[2022-09-21T21:35:28.903Z] Test passed after 1 failed attempt on release/14.2.
[2022-09-28T19:06:12.812Z] Test passed after 1 failed attempt on release/14.2.
[2023-10-17T10:39:08.451Z] Test passed after 1 failed attempt on fix/pattern-categories-capabilities.
[2023-10-17T11:12:10.485Z] Test passed after 1 failed attempt on fix/pattern-categories-capabilities.
[2023-10-17T12:35:00.151Z] Test passed after 2 failed attempts on fix/pattern-categories-capabilities.
[2023-10-17T13:09:06.753Z] Test passed after 2 failed attempts on fix/pattern-categories-capabilities.
[2023-10-18T09:38:06.429Z] Test passed after 2 failed attempts on fix/pattern-categories-capabilities.
[2023-10-18T13:34:55.510Z] Test passed after 1 failed attempt on fix/pattern-categories-capabilities.
[2023-10-19T08:29:25.187Z] Test passed after 1 failed attempt on fix/pattern-categories-capabilities.
[2023-10-19T16:21:11.835Z] Test passed after 1 failed attempt on fix/pattern-categories-capabilities.
[2023-10-20T07:41:22.992Z] Test passed after 2 failed attempts on fix/pattern-categories-capabilities.
[2023-10-20T09:52:52.032Z] Test passed after 2 failed attempts on rnmobile/reusable-block-title-dark-mode.
[2023-10-20T10:20:17.079Z] Test passed after 2 failed attempts on rnmobile/reusable-block-title-dark-mode.
[2023-10-20T10:39:44.927Z] Test passed after 1 failed attempt on trunk.
[2023-10-20T11:16:16.164Z] Test passed after 2 failed attempts on rnmobile/reusable-block-title-dark-mode.
[2023-10-20T11:23:52.251Z] Test passed after 1 failed attempt on trunk.
[2023-10-20T12:25:02.940Z] Test passed after 1 failed attempt on update/remove-string-from-pages-sidebar.
[2023-10-20T12:29:38.192Z] Test passed after 1 failed attempt on rnmobile/reusable-block-title-dark-mode.
[2023-10-20T13:39:18.092Z] Test passed after 1 failed attempt on update/remove-string-from-pages-sidebar.
[2023-10-20T13:41:22.678Z] Test passed after 1 failed attempt on trunk.
[2023-10-20T13:47:21.040Z] Test passed after 2 failed attempts on rnmobile/social-icon-background-dark-mode.
[2023-10-20T14:05:44.210Z] Test passed after 2 failed attempts on update/remove-string-from-pages-sidebar.
[2023-10-20T15:30:39.464Z] Test passed after 1 failed attempt on trunk.
[2023-10-20T15:55:54.990Z] Test passed after 2 failed attempts on 55224/migrate-BlockPatternList.
[2023-10-20T16:25:15.941Z] Test passed after 1 failed attempt on 6.4-rc2.
[2023-10-20T16:42:57.371Z] Test passed after 2 failed attempts on trunk.
[2023-10-20T20:07:01.288Z] Test passed after 1 failed attempt on try/WPBlockVariationScope-hidden.
[2023-10-20T20:15:06.440Z] Test passed after 1 failed attempt on try/content-transforms.
[2023-10-20T22:06:37.117Z] Test passed after 1 failed attempt on tweak/fullscreen-modal.
[2023-10-21T17:20:08.351Z] Test passed after 1 failed attempt on scripts-readme-typo.
[2023-10-21T18:23:20.751Z] Test passed after 1 failed attempt on scripts-readme-typo.
[2023-10-21T18:56:15.044Z] Test passed after 1 failed attempt on scripts-readme-typo.
[2023-10-22T07:20:17.943Z] Test passed after 1 failed attempt on docs/reorder-toc-create-block.
[2023-10-23T14:21:00.178Z] Test passed after 1 failed attempt on add/e2e-utils-editor-preferences.
[2023-10-23T15:26:23.017Z] Test passed after 2 failed attempts on fix/saving-buttons-a11y.
[2023-10-23T16:03:26.167Z] Test passed after 1 failed attempt on fix/navigation-block-allow-support-for-other-list-items-to-be-nested.
[2023-10-24T10:41:25.223Z] Test passed after 1 failed attempt on trunk.
[2023-10-24T14:10:32.177Z] Test passed after 1 failed attempt on test/ignore-android-build-files. 
  ● Pattern blocks › should allow a block with styles to be converted to a reusable block

    TimeoutError: waiting for selector `.block-editor-block-list__block[aria-label="Block: Pattern"]` failed: timeout 30000ms exceeded

      391 | 		await page.waitForSelector( syncToggleSelectorChecked );
      392 | 		await page.keyboard.press( 'Enter' );
    > 393 | 		const reusableBlock = await canvas().waitForSelector(
          | 		                                     ^
      394 | 			'.block-editor-block-list__block[aria-label="Block: Pattern"]'
      395 | 		);
      396 | 		expect( reusableBlock ).toBeTruthy();

      at new WaitTask (../../node_modules/puppeteer-core/src/common/DOMWorld.ts:813:28)
      at DOMWorld.waitForSelectorInPage (../../node_modules/puppeteer-core/src/common/DOMWorld.ts:656:22)
      at Object.internalHandler.waitFor (../../node_modules/puppeteer-core/src/common/QueryHandler.ts:78:19)
      at DOMWorld.waitForSelector (../../node_modules/puppeteer-core/src/common/DOMWorld.ts:511:25)
      at Frame.waitForSelector (../../node_modules/puppeteer-core/src/common/FrameManager.ts:1290:47)
      at Object.waitForSelector (specs/editor/various/pattern-blocks.test.js:393:40)
          at runMicrotasks (<anonymous>)
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label Sep 21, 2022
@Mamaduka Mamaduka mentioned this issue Sep 22, 2022
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Sep 22, 2022
@github-actions github-actions bot reopened this Sep 28, 2022
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Nov 24, 2022
@github-actions github-actions bot reopened this Oct 17, 2023
This was referenced Oct 17, 2023
Merged
Merged
github-actions bot referenced this issue Oct 20, 2023
@fluiddot
[RNMobile] Classic block: Add option to convert to blocks (#55461)
a00a5dd 
* Add option to convert Classic block to blocks in Missing block

* Add integration tests for Classic block

* Update `react-native-editor` changelog
@github-actions github-actions bot mentioned this issue Oct 20, 2023
Merged
github-actions bot referenced this issue Oct 20, 2023
[RNMobile] Synced Patterns: Ensure title is always visible (#55399)
4afae15 
Ensure the title section of Synced Patterns is visible within the editor when a block-based theme is used with a background that contrasts the device's dark/light mode.
@github-actions github-actions bot mentioned this issue Oct 20, 2023
Merged
github-actions bot referenced this issue Oct 20, 2023
@oandregal
Remove string from pages sidebar (#55510)
145ee70
This was referenced Oct 20, 2023
Closed
Merged
github-actions bot referenced this issue Oct 20, 2023
@artemiomorales @afercia
Image: Improve focus management in lightbox (#55428)
fd8bdfe 
* Improve focus management

This commit removes the logic to set focus differently
based on event.pointerType and instead sets focus on the
dialog itself when the lightbox opens, and on the lightbox
trigger when the lightbox closes.

* Add delay before focusing when closing lightbox

* Put focus back on close button when opening lightbox

It turns out that placing focus on the modal was causing
inconsistent behavior in Safari, so I've put the focus back
on the close button when the lightbox opens, which
performs predictably.

I've also added a tabindex to the image, which prevents
the focus ring from erroneously showing when opening the lightbox
with a mouse in Chrome and Firefox.

* Move focus to the dialog when opening the lightbox.

* Fix SVG markup.

* Consistent indentation with spaces.

* Remove unnecessary tabindex

---------

Co-authored-by: Andrea Fercia <[email protected]>
This was referenced Oct 20, 2023
Open
Open
Open
Merged
Merged
Merged
Merged
Merged
github-actions bot referenced this issue Oct 24, 2023
@WunderBart
Performance tests: Fix canvas locator timeout (#55441)
ade7e64
@github-actions github-actions bot mentioned this issue Oct 24, 2023
Merged
@Mamaduka Mamaduka removed their assignment Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix failing quote to reusable block conversion e2e test WordPress/gutenberg
2 participants
@Mamaduka @priethor