Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Block: randomly unable to successfully drag & drop in List View #43881

Closed
annezazu opened this issue Sep 5, 2022 · 3 comments
Closed
Labels
[Block] Group Affects the Group Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended

Comments

@annezazu
Copy link
Contributor

annezazu commented Sep 5, 2022

Description

When trying to drag and drop a row block (variation of group) in List View, drag and drop randomly does not work causing the blocks selected to remain in their current location. It's not clear what the pattern is but it is replicable.

This was originally found in the sixteenth call for testing for the FSE Outreach Program:

In the list view, when I drag and drop the row:

  • sometimes (about a third of the time), the row does not move, it just bounces back to where it was.
  • I have seen this behavior often in the list view when I drag and drop things to move around.

It is a mystery to me when or why this happens. It seems to happen more when I drop to the end of the post, but it also happens when I drop the row between two paragraphs. This behavior stops and starts and I cannot tell why. It seems like once the problem starts, it continues until I drag and drop another block.

Step-by-step reproduction instructions

  1. Open the Post Editor.
  2. Add a Row block with two images and a spacer between them along with various other pieces of content (images, paragraphs, etc)
  3. Open List View.
  4. Try to drag and drop the row block throughout the other blocks on the post.
  5. Notice that it randomly fails.

Screenshots, screen recording, code snippet

row.drag.and.drop.mov

Environment info

  • WordPress 6.0.2
  • GB 14.0.2
  • TT2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@annezazu annezazu added [Type] Bug An existing feature does not function as intended [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Block] Group Affects the Group Block labels Sep 5, 2022
@talldan
Copy link
Contributor

talldan commented Sep 7, 2022

I think it happens whenever you drop on the empty space after the list of blocks. The same happens with normal block drag and drop, and list view uses most of the same code - #32438

edit: oh yeah, I see it was mentioned in that issue.

@Thelmachido
Copy link

Yes, it is quite difficult to reproduce this. However, I can still reproduce this with the same environment Anne shared

Screen.Recording.2022-09-22.at.15.28.36.mov

WordPress 6.0.2
Gutenberg 14.0.2 active and deactivated
TT2

@andrewserong
Copy link
Contributor

I believe this issue has largely been addressed now between #49742 and #50726 (allow dragging outside of the immediate list view area).

I'll close out this issue now, but do feel free to re-open if the issue recurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Feature] Drag and Drop Drag and drop functionality when working with blocks [Feature] List View Menu item in the top toolbar to select blocks from a list of links. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants