Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supports.typography.alignment argument so that blocks can use AlignmentControl automatically. #38427

Closed
jhned opened this issue Feb 2, 2022 · 0 comments · Fixed by #59531
Assignees
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Technical Feedback Needs testing from a developer perspective. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jhned
Copy link
Contributor

jhned commented Feb 2, 2022

What problem does this address?

It's difficult to add the AlignmentControl component to a block. To filter it in on a block that doesn't support it, it's not a simple matter of filtering the block settings, but rather of filtering the whole edit function. That seems heavy-handed.

What is your proposed solution?

Add an argument under the supports.typography object that accepts "alignment." If present, AlignmentControl is automatically added to the Block Toolbar.

@annezazu annezazu added [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Technical Feedback Needs testing from a developer perspective. labels Feb 22, 2022
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 30, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Technical Feedback Needs testing from a developer perspective. [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants