Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image size settings can be confusing #38050

Closed
jameskoster opened this issue Jan 18, 2022 · 7 comments
Closed

Image size settings can be confusing #38050

jameskoster opened this issue Jan 18, 2022 · 7 comments
Labels
[Block] Image Affects the Image Block [Block] Post Featured Image Affects the Post Featured Image Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

Screenshot 2022-01-18 at 14 30 28

We have "Image size" to determine which version of the source file to use.

Then Width and Height specify how much space the image should occupy on the page.

And finally there are percentage-based presets which set the Width and Height relative to the selected "Image size".


Problems

It's not clear which Image Size one should use, or what Image Size means, given there are dedicated inputs for width and height.

It is possible to mistakenly use inappropriate settings. E.G. set the height and width to some small value, but still use the full size Image Size. This is not performant. Or vice versa – set a large height / width, then use an Image Size that is too small, which results in a blurry image.

It's not really clear what the percentage presets actually do. I had to go in to Settings > Media to understand what is going on there. I'm also not entirely sure how useful this setting is.


At the very least it seems we can better communicate the relationship between Image Size and Height / Width. In the past I think @jasmussen has suggested displaying the pixel values of each size in the dropdown:

Screenshot 2022-01-18 at 14 41 23

But in the end I wonder if the Image Size setting needs to be so prominent, or whether we can intelligently set it based on the Height / Width values.

@jameskoster jameskoster added Needs Design Needs design efforts. [Block] Image Affects the Image Block [Block] Post Featured Image Affects the Post Featured Image Block labels Jan 18, 2022
@jasmussen
Copy link
Contributor

I created #38068 for some general design improvements to the image block, it includes some of the conversation around improving the Size selector as well.

@glendaviesnz
Copy link
Contributor

This is also now relevant in the Gallery block which uses nested Images blocks, and when the 'crop images' option is toggled on the size selector can appear to have no impact at all.

@Mamaduka
Copy link
Member

This probably will be resolved by #49112.

cc @richtabor

@richtabor
Copy link
Member

This probably will be resolved by #49112.

In part, yes. The "Size" select isn't part of that PR.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 14, 2023
@jordesign
Copy link
Contributor

@richtabor - do you think that last remaining item is sufficiently covered by the work being considered in #38068? Worth consolidating?

@richtabor
Copy link
Member

Here's what we have currently (no % based size group):

CleanShot 2023-09-14 at 09 29 43

Unifying the dimensions panel to include height/width would help reduce the confusion, but I think we're sitting in a decent spot currently.

@jameskoster
Copy link
Contributor Author

Agreed, this UI has improved a lot. Let's close this 🥂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block [Block] Post Featured Image Affects the Post Featured Image Block Needs Design Needs design efforts. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

6 participants