-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Color Picker: Refine the look of "unset" color picker #36998
Comments
Hi! FWIW I think the checkerboard thing is confusing. I'm used to seeing that from photoshop and what not, but I'm not sure users know what to do with it. And, I was just keeping those thoughts to myself til one of our volunteers reached out with similar feedback: it's not clear what the checkerboard area is for. I'm gathering it's a preview, but would it make more sense to just use the preview we can see in the live edit area? Also, when we put in colors for the text, background, links, link background, and then all of the custom colors and default palettes together, it gets kind of unruly. Here's what I'm seeing: |
Also, I've noticed when I set a color, say, for the text, the boxy area shows that as the background color with a different text color (like white). I'm not sure what that means. You can see it in the video here, which I filed for another issue. Ignore the sound and just watch for the boxes: |
What if instead of trying to indicate unset, it just said "Theme Default" or something, and/or showed that color? |
I'm going to close this one for now. The color in the itemgroup does look unset, even if the color in the expanded color panel looks transparent. But the color panel is undergoing its own iterations, so this one seems like it's drifting out of date. |
Extracting from this comment, the checkerboard background currently in place for the Custom Color card indicates transparency, but it should probably lean towards indicating "unset" instead. Also:
There are the beginnings of a PR in
try/polish-unset-color-indicator-further
, but it isn't quite visually succesful:It also opens the question: should the checkerboard backgroud remain in place for when a color with opacity is created?
The text was updated successfully, but these errors were encountered: