Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Welcome Guide to Styles More Menu #36544

Closed
annezazu opened this issue Nov 16, 2021 · 14 comments · Fixed by #37180
Closed

Add Welcome Guide to Styles More Menu #36544

annezazu opened this issue Nov 16, 2021 · 14 comments · Fixed by #37180
Assignees
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

With the introduction of the Welcome Guide for the site editor #32844, it would be great to have a way to trigger it once more.

Screen Shot 2021-11-16 at 2 35 16 PM

What is your proposed solution?

Add it as an option here:

Screen Shot 2021-11-16 at 2 39 43 PM

@annezazu annezazu added [Type] Enhancement A suggestion for improvement. Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json labels Nov 16, 2021
@shaunandrews
Copy link
Contributor

Seems like it should go in the top toolbar "..." menu instead, like the Welcome Guide is for the post editor:

image

We're getting a little carried away with all these different "..." menus. Worth noting the one you suggested is only visible if the Styles sidebar is open.

@annezazu
Copy link
Contributor Author

AFAIK #32844 handles having it in the usual spot!

@Mamaduka
Copy link
Member

I think the "Styles" ellipsis button has a different purpose, similar to Dimensions one. Welcome Guide might be a little out of place there.

@talldan also pointed out a few issues with the current spit Welcome Guide solution - #36172 (comment). I would love to hear more feedback on this one as well 🙇

@mtias
Copy link
Member

mtias commented Nov 16, 2021

The main "welcome guide" is for the site editor, not for styles. It seems styles invoke its own when it's opened for the first time, so it makes sense to reinitialize that it's there.

@Mamaduka
Copy link
Member

Another question: Do we want only to invoke Styles' welcome guide when a user visits Editor via "Appearance > Styles"?

P.S. I'll do a follow-up PR tomorrow.

@shaunandrews
Copy link
Contributor

The main "welcome guide" is for the site editor, not for styles.

I doubt this separation is obvious or makes sense to anyone outside of the people on this thread. The only way to see the styles is to use the site editor. 🤷

@mtias
Copy link
Member

mtias commented Nov 17, 2021

@shaunandrews can you clarify what would open when clicking "welcome guide" in your suggestion? Because there's already a welcome guide attached to the site editor.

@shaunandrews
Copy link
Contributor

Its not clear to me what the distinction is between the two guides. Right now, when I click "Appearance -> Editor" and "Appearance -> Styles" I see the "Welcome to Styles" guide. It seems the only way to trigger the Site Editor guide is to close the styles sidebar. Its really finicky and the logic is not at all obvious. Here's the how I first encountered both guides:

  1. I went to the "Appearance -> Styles" and I immediately saw the styles welcome guide, since (for whatever reason) my styles sidebar was open.
  2. I kept the sidebar open, and made a few changes.
  3. A few minutes later I closed the style sidebar and was immediately shown the site editor welcome guide. This was very confusing, since I wasn't aware what I did to trigger it, and it was so similar to the style guide that I thought it was a bug.

Maybe it should be a single welcome guide that covers both the site editor and styles sidebar? This seems like the best solution considering that the editor welcome guide is a single screen, which mentions styles.

image

Or, if we're sure we want two, maybe we label them something more descriptive in the menu, and figure out a better way to trigger them when first experiencing the site editor.

image

@javierarce
Copy link
Contributor

I like the idea of having two entry points for each guide since it's confusing that the same button triggers a different one depending on whether the styles are toggled or not.

Having just one guide could work, but there's a significant imbalance on the content right now: an inner functionality of the site editor (styles) presents more information than the general guide. So if we wanted to merge those guides, we'd probably need to address that.

In any case, those solutions won't scale well as soon as we want to add more slides or guides. So I think at some point, we'll need to rethink how we present this information to the users (in my mind, the ideal solution could be having a general guide organized by sections for each feature).

@Mamaduka
Copy link
Member

Do we have the final design/specs for this issue? I can start working on follow-up PR.

@Mamaduka
Copy link
Member

Hi, everyone

I just wanted to check in again, if we have the final design for this issue.

Side note: The separate "Styles" entry point was removed recently - #36637.

@shaunandrews
Copy link
Contributor

I just wanted to check in again, if we have the final design for this issue.

I guess the original proposal of adding it to the Styles sidebar "..." menu is still the best solution.

@mtias
Copy link
Member

mtias commented Dec 3, 2021

@noisysocks this is a nice to have for 5.9, can be easily punted

@Mamaduka
Copy link
Member

Mamaduka commented Dec 3, 2021

@mtias, I've got to push another update for Welcome Guide and will try to include this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants