Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Featured Image Block Consolidate double dimensions panel #36536

Closed
annezazu opened this issue Nov 16, 2021 · 4 comments · Fixed by #36540
Closed

Post Featured Image Block Consolidate double dimensions panel #36536

annezazu opened this issue Nov 16, 2021 · 4 comments · Fixed by #36540
Assignees
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

What problem does this address?

This came up as part of the eleventh call for testing for the FSE outreach program from @paaljoachim:

But instead I noticed a Dimensions panel with Height and Width. + Another Dimensions panel further below with a + in it. (Confusing having two Dimenions kinds of panels. I did not know what Height/Width I should add so I randomly added 300px Height and 600px Width. Doing so the Scale option showed up. To where I could select Cover – Contain or Fill.

Screen Shot 2021-11-15 at 7 30 47 PM

What is your proposed solution?

Consolidate these sections :D cc @stacimc as we chatted about this.

@paaljoachim
Copy link
Contributor

Thank you Anne and @stacimc Staci!

@annezazu
Copy link
Contributor Author

This has somehow returned in 5.9 RC2 :D

Screen Shot 2022-01-11 at 4 04 58 PM

Found this while writing documentation for 5.9: WordPress/Documentation-Issue-Tracker#69 cc @stacimc

@annezazu annezazu reopened this Jan 12, 2022
@Mamaduka
Copy link
Member

@annezazu, it looks like we forgot to backport the changes. Marked PR to be backported in minor release - #36540 (comment)

@noisysocks
Copy link
Member

We can keep the issue closed as the issue is fixed in the plugin. Since #36540 has the "Backport to minor" label, it will end up in 5.9.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Featured Image Affects the Post Featured Image Block [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
5 participants