Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the navigation block uses justify right, the overlay can't be closed #36102

Closed
carolinan opened this issue Nov 1, 2021 · 2 comments · Fixed by #36105
Closed

When the navigation block uses justify right, the overlay can't be closed #36102

carolinan opened this issue Nov 1, 2021 · 2 comments · Fixed by #36105
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@carolinan
Copy link
Contributor

Description

When the navigation block has lots of content and the menu items are set to justify right, the overlay can not be closed because the menu seems to be on top of the close button.

Step-by-step reproduction instructions

  1. Add a navigation block. Add lots of content or use an existing menu in the theme test data.
  2. Select the toolbar option to justify items to the right.
  3. Enable the overlay menu.
  4. View the block on the front and open the overlay.
  5. Try closing the overlay.

Note: I did not test on RTL.

Screenshots, screen recording, code snippet

With right justification:
menu item on top of close button

Without any justification setting:
without justification, the close button is not covered.

Environment info

WordPress 5.8.1, Gutenberg current trunk, Did not test with older versions.
Tested with Twenty Twenty-Two and Emptytheme.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@carolinan carolinan added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Nov 1, 2021
@jasmussen
Copy link
Contributor

Taking a look, thanks for the ticket!

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 1, 2021
@jasmussen
Copy link
Contributor

Should be fixed by #36105.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants