Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated classnames from Navigation Link block #35237

Closed
tellthemachines opened this issue Sep 30, 2021 · 0 comments · Fixed by #35358
Closed

Remove deprecated classnames from Navigation Link block #35237

tellthemachines opened this issue Sep 30, 2021 · 0 comments · Fixed by #35358
Labels
[Block] Navigation Link Affects the Navigation Link Block

Comments

@tellthemachines
Copy link
Contributor

What problem does this address?

After #33918 and #34171, there are a some extra classnames on Navigation Link block that are no longer needed. It would be good to remove them before the block lands in core.

List of classnames we can remove:

  • wp-block-navigation-link__container
  • wp-block-navigation-link__content (one of the e2e tests is using this one as a selector so we should also update that)
  • wp-block-navigation-link__submenu-icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Navigation Link Affects the Navigation Link Block
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated classnames from Navigation Link block WordPress/gutenberg
1 participant
@tellthemachines