Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation editor: Speed issues with saving and loading #35046

Closed
Tracked by #29102
adamziel opened this issue Sep 22, 2021 · 2 comments
Closed
Tracked by #29102

Navigation editor: Speed issues with saving and loading #35046

adamziel opened this issue Sep 22, 2021 · 2 comments

Comments

@adamziel
Copy link
Contributor

This is a copy&paste of a comment by @spacedmonkey from 34541:


I wrote a little script that creates a new menu and creates 500 items. This script looks like this.

function create_mock_menu( ) {
	$rand = rand();
	for ($x = 0; $x <= 500; $x++) {
		$test = wp_insert_post( [ 'post_type' => 'nav_menu_item', 'post_status' => 'publish', 'menu_order' => $x,'post_title' => 'Title '.$x ] );
		update_post_meta( $test, '_menu_item_type', 'custom' );
		update_post_meta( $test, '_menu_item_url', '#' );

		wp_set_post_terms( $test, 'Test menu '.$rand, 'nav_menu' );
	}
}

My testing, there seem to be some performance issues with saving 500 items. See this video.

Screen.Recording.2021-09-19.at.23.55.22.mov

Issues, I spotted.

  1. Loading is very slow and does start render when items are coming in, but waits for all items to load.
  2. When pressing save, the save button should be disabled.
  3. When pressing save, a spinner or other something should show the user that menu is saving.
@adamziel adamziel changed the title Navigation editor: Speed problems with saving and loading Navigation editor: Speed issues with saving and loading Sep 22, 2021
@spacedmonkey
Copy link
Member

Is this is a duplicate of #34999 ?

@Mamaduka
Copy link
Member

Closing the issue since the editor is no longer maintained and has been removed from the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants