Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: enable "copy to clipboard" functionality with keyboard #34795

Closed
3 tasks
Tracked by #34284
ciampo opened this issue Sep 13, 2021 · 2 comments
Closed
3 tasks
Tracked by #34284

Components: enable "copy to clipboard" functionality with keyboard #34795

ciampo opened this issue Sep 13, 2021 · 2 comments
Labels
[Feature] Component System WordPress component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components

Comments

@ciampo
Copy link
Contributor

ciampo commented Sep 13, 2021 •
edited
Loading

Part of #34284

What

Add keyboard support for the "copy to clipboard" functionality

Why

Not all users interact with the color picker with a pointer device

A/C

  • The DOM element that can be currently clicked to copy to clipboard should be flagged as a button, and have a meaningful label (e.g. click to copy to clipboard)
    • This should work keeping in mind the already present tooltip
  • When the above mentioned DOM element has focus, pressing spacebar should copy the value to the clipboard
@ciampo ciampo mentioned this issue Sep 13, 2021
Closed
31 tasks
@ciampo ciampo added [a11y] Keyboard & Focus [Feature] Component System WordPress component system [Package] Components /packages/components [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Sep 13, 2021
@stokesman
Copy link
Contributor

Seems like this has been resolved by #41222. Maybe the only qualm would be that the new button’s label ”Copy” is too terse.

@ciampo
Copy link
Contributor Author

ciampo commented Jun 9, 2022 •
edited
Loading

Agreed — maybe we could change the text to "Copy to clipboard"?

@ciampo ciampo closed this as completed Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Component System WordPress component system [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ciampo @stokesman