Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview issues: Theme Supports for Blocks #34653

Closed
scruffian opened this issue Sep 8, 2021 · 1 comment
Closed

Overview issues: Theme Supports for Blocks #34653

scruffian opened this issue Sep 8, 2021 · 1 comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.

Comments

@scruffian
Copy link
Contributor

In order to connect block themes to Global Styles, aspects of the themes design need to be described in theme.json, rather than in CSS. To achieve this we need to add support for different properties to many of our blocks. Rather than just add support for every property to every block, this issue lists issues which arise from real world themes and their needs, specifically the Blockbase theme. Each of these issues represents an aspect of theme design which is currently implemented in CSS but should be done in the theme.json. As these issues are resolved we will be able to remove CSS from Blockbase (and other block themes) and move the configuration to theme.json.

@scruffian scruffian added [Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Sep 8, 2021
@scruffian
Copy link
Contributor Author

This is tracked in #33447, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Development

No branches or pull requests

1 participant