Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components: Rename PolymorphicComponent type to WordPress Component #34291

Closed
2 tasks
ciampo opened this issue Aug 25, 2021 · 0 comments · Fixed by #34330
Closed
2 tasks

Components: Rename PolymorphicComponent type to WordPress Component #34291

ciampo opened this issue Aug 25, 2021 · 0 comments · Fixed by #34330
Assignees
@ciampo
Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@ciampo
Copy link
Contributor

ciampo commented Aug 25, 2021 •
edited
Loading

Required by #33960

Why

The PolymorphicComponent type name can be confusing (and refers to an implementation detail, components polymorphism). WordPressComponent is a better name.

What

We should refactor all of the references to PolymorphicComponent* types (defined in https://github.com/WordPress/gutenberg/blob/trunk/packages/components/src/ui/context/polymorphic-component.ts) and rename them to WordPressComponent*

A/C

  • Rename all instances of PolymorphicComponent* types to WordPressComponent*
  • Potentially add a changelog entry
@ciampo ciampo added [Feature] Component System WordPress component system [Package] Components /packages/components [Type] Enhancement A suggestion for improvement. labels Aug 25, 2021
@ciampo ciampo mentioned this issue Aug 26, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ciampo ciampo

Labels
[Feature] Component System WordPress component system [Package] Components /packages/components [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Components: Rename PolymorphicComponent* types to WordPressComponent* WordPress/gutenberg
1 participant
@ciampo