Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery block refactor: Console errors thrown in some instances when replacing images via Media Library #34098

Closed
2 tasks done
andrewserong opened this issue Aug 17, 2021 · 3 comments
Assignees
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended

Comments

@andrewserong
Copy link
Contributor

andrewserong commented Aug 17, 2021

Description

Following Gallery block refactor PR testing instructions in: #29882, I noticed the following issue:

If certain steps are followed, when replacing existing images in the refactored gallery via Media Library, console errors are thrown (it doesn't appear to affect functionality).

image

Step-by-step reproduction instructions

  1. Check out Gallery refactor PR to local dev env
  2. Insert a gallery block and add one image via the Media library
  3. Save the post and reload the editor window
  4. Replace the image in the existing gallery by clicking on the Media Library button and upload 2 new images to replace the existing one
  5. Once the images are replaced, notice the console errors

Screenshots, screen recording, code snippet

gallery-refactor-replace-images

Environment info

  • WP 5.8

Pre-checks

  • I have searched the existing issues.
  • I have tested with all plugins deactivated except Gutenberg.
@andrewserong andrewserong added [Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended labels Aug 17, 2021
@glendaviesnz glendaviesnz self-assigned this Aug 18, 2021
@glendaviesnz glendaviesnz changed the title Gallery block refactor: Console errors thrown when replacing images with Jetpack plugin active Gallery block refactor: Console errors thrown in some instances when replacing images via Media Library Aug 18, 2021
@glendaviesnz
Copy link
Contributor

It turns out that this can be replicated without Jetpack installed as long as certain steps are followed. Have updated the description.

@andrewserong
Copy link
Contributor Author

Great, thanks for confirming and updating the description, Glen!

@talldan
Copy link
Contributor

talldan commented Aug 19, 2021

Fixed by #34133

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants