Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site Editor should be available for child themes if the appropriate index.html file exists in the parent #33959

Closed
richtabor opened this issue Aug 9, 2021 · 1 comment · Fixed by #34354
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress

Comments

@richtabor
Copy link
Member

What problem does this address?

Currently a theme requires a block-templates/index.html file to enable the Site Editor UI (which makes sense). However, if a child theme of the block based theme does not have an index.html file, it is opted-out of the experience. This means that child themes will have to duplicate index.html files just to be opted into the Site Editor (which isn't ideal if a child theme does not change the index blogroll view).

What should occur?

A parent theme's block-templates/index.html file should be available within child themes, which means child themes of Site Editor capable themes can use the Site Editor without having to duplicate that index file.

@richtabor richtabor added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Aug 9, 2021
@annezazu annezazu added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Aug 9, 2021
@Mamaduka
Copy link
Member

Related #25612.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants