Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template Part Focus Mode #33926

Closed
13 tasks done
mtias opened this issue Aug 6, 2021 · 10 comments
Closed
13 tasks done

Template Part Focus Mode #33926

mtias opened this issue Aug 6, 2021 · 10 comments
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@mtias
Copy link
Member

mtias commented Aug 6, 2021

This issue tracks short-term work to be done on what has been referred to as "isolated template part" mode. This is a view that just focuses on a single template part (like a header) and is available for any template part. It also outlines the role this will play as part of turning existing widget areas into block template parts. This last part is only tentatively written and is not scoped out pending research on both the widgets work and the navigation screen work.

Design overview: #29148.

Followups

Once the internal UX of editing template parts isolated from their containing template is in a good place, research should continue on how should existing widget areas transition to more ergonomic template parts.

@mtias mtias added [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. [Block] Template Part Affects the Template Parts Block [Feature] Template Editing Mode Related to the template editor available in the Block Editor labels Aug 6, 2021
@mtias mtias mentioned this issue Aug 6, 2021
57 tasks
@draganescu
Copy link
Contributor

The canvas should be resizable with a drag handle. (See pattern directory previews.)

@mtias / @jameskoster what is the use of this handle to resize? I see in later designs in #29148 that it went away.

@mtias
Copy link
Member Author

mtias commented Aug 31, 2021

We want to introduce viewport resizers through template parts to then scale it up to the whole editor for responsive previewing. (Similar to the pattern directory.)

@noisysocks
Copy link
Member

Hi! @kevin940726 and I are going to start working our way through this list.

Quick question: What do you mean by "should be accessible from ... The Sidebar Menu"? What is the sidebar menu?

@draganescu
Copy link
Contributor

What is the sidebar menu?

It's the menu that appears when clicking the "W" logo when editing a block theme.

@kevin940726
Copy link
Member

What is the sidebar menu?

It's the menu that appears when clicking the "W" logo when editing a block theme.

Oh okay I guessed it wrong 😅. I thought it's the right sidebar (inspector).

Isn't the editor already accessible in the sidebar menu then?

@mtias
Copy link
Member Author

mtias commented Sep 8, 2021

Yes, it was checked in the list but seems to have been unchecked since :)

@kevin940726
Copy link
Member

In the Inspector, the settings for the Template Part should be visible in the document tab.

As mentioned in #30641 (comment), I don't think this is possible now. I think we should mark it as wont-fix until we have a proper solution to the underlying architecture?

@noisysocks
Copy link
Member

List view as an icon button.

I checked this one off now that #35170 is merged meaning you can edit a template part via the ellipsis button in a List View. Perhaps we can revisit having a dedicated icon after WP 5.9.

@noisysocks
Copy link
Member

I think we can close this out now that #35512 is merged. No doubt there's plenty more to iterate on but I think things are in good shape for WP 5.9. Really nice work @kevin940726 and @jameskoster! ❤️🎉

@mtias
Copy link
Member Author

mtias commented Oct 28, 2021

Excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Template Editing Mode Related to the template editor available in the Block Editor [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
Development

No branches or pull requests

4 participants