Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation screen: can't move links into a submenu with keyboard only #33271

Closed
Tracked by #29102
tellthemachines opened this issue Jul 8, 2021 · 3 comments
Closed
Tracked by #29102
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@tellthemachines
Copy link
Contributor

tellthemachines commented Jul 8, 2021

Description

It should be possible to move a Navigation link into or out of a submenu using only the keyboard. The "Move to" block option, which exists for regular Navigation links, isn't showing on this screen:

Screen Shot 2021-07-09 at 11 03 35 am

Step-by-step reproduction instructions

Add several items to Navigation, including submenus. Try to move items into or out of the submenus (or even from one submenu to another) using only the keyboard.

Expected behaviour

Expect all block functionality to be available when using only keyboard.

Actual behaviour

Screenshots or screen recording (optional)

Code snippet (optional)

WordPress information

  • WordPress version: NA
  • Gutenberg version: 11.0
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme (e.g. Twenty Twenty-One)? Yes

Device information

  • Device:
  • Operating system:
  • Browser:
@tellthemachines tellthemachines added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jul 8, 2021
@tellthemachines tellthemachines added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. labels Jul 8, 2021
@javierarce
Copy link
Contributor

javierarce commented Jul 8, 2021

In a previous comment that I embarrassedly deleted from this issue (sorry!), I pointed out that moving elements (in general) should be extended to other blocks… I had forgotten about the "Keyboard shortcuts" list 🙈 and just tried the most obvious combinations (like shift , , shift , etc.) unsuccessfully.

But it turns out, that the combination to move blocks up and down are T and Y.

Leaving aside that those are complicated keyboard shortcuts (to type and to remember), I guess that to move things in and out submenus, we would need to come up with some shortcuts with a similar structure. Plus, if we could generalize them to be used elsewhere (to move blocks to their parent element, for instance), that would be a win-win.

@tellthemachines
Copy link
Contributor Author

In a previous comment that I embarrassedly deleted from this issue (sorry!)

No worries, just realised I messed up the issue description too 😂

But it turns out, that the combination to move blocks up and down are ⇧ ⌥ ⌘ T and ⇧ ⌥ ⌘ Y.

Those shortcuts only move blocks between their current siblings, not between nesting levels. But to move between nesting levels, we have Options > Move to which was implemented in #22453:

Screen Shot 2021-07-09 at 11 02 58 am

(Clicking the "Move to" button takes us into Select mode, where the left and right arrow keys can be used to move in and out of blocks and pressing Enter drops the block in the current cursor position.)

For some reason, I thought that option wasn't showing in the Navigation block children, but turns out it is! So this isn't an issue for the block, but it is for the screen, where that option doesn't show in the block options:

Screen Shot 2021-07-09 at 11 03 35 am

I'll update this issue accordingly.

@tellthemachines tellthemachines changed the title Navigation block: can't move links into a submenu with keyboard only Navigation screen: can't move links into a submenu with keyboard only Jul 9, 2021
@tellthemachines tellthemachines added [Feature] Navigation Screen and removed [Block] Navigation Affects the Navigation Block labels Jul 9, 2021
@Thelmachido
Copy link

Closing this issue due to the Navigation Screen project being moved to an inactive status on the feature projects page in coordination with the project leads. If this work is picked back up, issues can be revisited and reopened as needed.

@Thelmachido Thelmachido closed this as not planned Won't fix, can't repro, duplicate, stale Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants