Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget Editor: Legacy widget scrollbars #33115

Closed
dreamwhisper opened this issue Jun 30, 2021 · 0 comments · Fixed by #33191
Closed

Widget Editor: Legacy widget scrollbars #33115

dreamwhisper opened this issue Jun 30, 2021 · 0 comments · Fixed by #33191
Assignees
@kevin940726
Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress

Comments

@dreamwhisper
Copy link

Description

Legacy widgets show scrollbars in a variety of themes.

Step-by-step reproduction instructions

Please list the steps needed to reproduce the bug. For example:

  1. Make sure several legacy widgets are added to sidebars, then update to WP 5.8 RC1.
  2. Activate various themes and note scrollbars.

This appears to be from margin on elements inside, including .widget.

Previously seen on #32260 (comment)

Expected behaviour

Scrollbars will not be present.

Actual behaviour

Scrollbars are present.

Screenshots or screen recording (optional)

From Twenty X themes:
Screen Shot 2021-06-30 at 11 03 41 AM

From Margin on the ul
Screen Shot 2021-06-30 at 11 04 44 AM

Margin on li
Screen Shot 2021-06-30 at 3 33 46 PM

Non-Twenty themes
Screen Shot 2021-06-30 at 10 04 19 AM

Screen Shot 2021-06-30 at 10 04 55 AM

Screen Shot 2021-06-30 at 3 50 48 PM

WordPress information

  • WordPress version: 5.8 RC1
  • Gutenberg version: Not installed
  • Are all plugins except Gutenberg deactivated? Yes
  • Are you using a default theme Yes and No

Device information

  • Device: Mac
  • Operating system: 10.15.x
  • Browser: Chrome
@johnstonphilip johnstonphilip added [Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. labels Jun 30, 2021
@kevin940726 kevin940726 self-assigned this Jul 2, 2021
@kevin940726 kevin940726 mentioned this issue Jul 5, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevin940726 kevin940726

Labels
[Block] Legacy Widget Affects the Legacy Widget Block - used for displaying Classic Widgets [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix legacy widget height overflow WordPress/gutenberg
3 participants
@dreamwhisper @johnstonphilip @kevin940726