Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify drag and drop behavior across Image block and Gallery block #32820

Closed
Tracked by #33683
critterverse opened this issue Jun 18, 2021 · 3 comments
Closed
Tracked by #33683

Unify drag and drop behavior across Image block and Gallery block #32820

critterverse opened this issue Jun 18, 2021 · 3 comments
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Drag and Drop Drag and drop functionality when working with blocks Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@critterverse
Copy link
Contributor

Potential follow-up to #32819

Currently in Gutenberg, you can drag an image on top of an existing Image block, which will upload the new image and replace the current one. The drop zone covers the full area of the block and is indicated by a blue overlay color with a CTA. The drop zone looks exactly the same on the Gallery block but instead of replacing, the new image is added to the gallery.

Issue #32819 proposes making both of these interactions available for the Image block within a single drag motion. Perhaps the same behavior could be extended to the Gallery block:

gallery-add-replace.mp4

This would allow a user to go seamlessly from one image to two images, and from two images to three images, using the exact same interaction pattern. This could be a part of ongoing efforts to unify the Image block and Gallery block more closely.

@critterverse critterverse added [Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Drag and Drop Drag and drop functionality when working with blocks Needs Design Feedback Needs general design feedback. labels Jun 18, 2021
@paaljoachim
Copy link
Contributor

Thank you for adding both the issues Channing! @critterverse

@glendaviesnz Glen can you take a look at both issues?
As this can likely be added to the updated Gallery block.

@glendaviesnz
Copy link
Contributor

glendaviesnz commented Jun 21, 2021

Thanks @paaljoachim and @critterverse - I have added both of these to the Gallery refactor project board so we don't forget to take a look at them once the main refactor is merged.

@glendaviesnz
Copy link
Contributor

This has been fixed at some point. If dropping a new image between existing images it adds to the gallery, but if dropping on top of ane existing image that image is replaced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Gallery Affects the Gallery Block - used to display groups of images [Feature] Drag and Drop Drag and drop functionality when working with blocks Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
No open projects
Development

No branches or pull requests

4 participants