Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid CSS in the block editor styles for .block-editor-block-variation-transforms #32181

Closed
pavel-mailpoet opened this issue May 25, 2021 · 3 comments · Fixed by #32305
Closed

Invalid CSS in the block editor styles for .block-editor-block-variation-transforms #32181

pavel-mailpoet opened this issue May 25, 2021 · 3 comments · Fixed by #32305
Assignees
@jasmussen
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@pavel-mailpoet
Copy link

Description

The styles for the rule .block-editor-block-variation-transforms .components-dropdown-menu__toggle:focus:not(:disabled) are not valid css.
And when I try to include the CSS in our plugin, our compilation fails because the stylesheet is not valid. See the error.

Screen Shot on 2021-05-25 at 09-12-20

I think it is because there are vanilla CSS variables and SASS variables combined in the source code and I don't think SASS supports that.
@talldan talldan added [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Type] Bug An existing feature does not function as intended CSS Styling Related to editor and front end styles, CSS-specific issues. labels May 28, 2021
@talldan
Copy link
Contributor

talldan commented May 28, 2021

cc @ntsekouras.

@ntsekouras
Copy link
Contributor

👋 - I guess this is probably related to this: https://sass-lang.com/documentation/breaking-changes/css-vars and this:
#27968.

@jasmussen can you take a look here as you have more experience on these 😄 ?

@jasmussen jasmussen mentioned this issue May 28, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label May 28, 2021
@jasmussen
Copy link
Contributor

Created #32305 in hopes to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasmussen jasmussen

Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Block Variations Block variations, including introducing new variations and variations as a feature [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Try: Make focus style valid CSS. WordPress/gutenberg
4 participants
@talldan @jasmussen @ntsekouras @pavel-mailpoet