Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight equivalent blocks in query #30529

Open
Tracked by #41405
jameskoster opened this issue Apr 6, 2021 · 3 comments
Open
Tracked by #41405

Highlight equivalent blocks in query #30529

jameskoster opened this issue Apr 6, 2021 · 3 comments
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@jameskoster
Copy link
Contributor

When working with blocks inside a query, it is possible to pseudo-select multiple blocks of the same type at once, and see changes reflected in multiple locations. This is best described with a short video:

multi-block.mp4

However, before the interaction occurs (moving the block in the video) there is no indication that multiple blocks will be affected.

Two areas we can improve the clarity here:

  1. When hovering the Post Title block in List View, all instances in the query could be highlighted on the canvas rather than just one
  2. When the Post Title block is selected, all instances in the query could be outlined on the canvas

I propose that highlighting the pseudo-selected blocks in some way will make these interactions feel a little less jarring.

@jameskoster jameskoster added Needs Design Needs design efforts. [Block] Query Loop Affects the Query Loop Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 6, 2021
@paaljoachim
Copy link
Contributor

Hey James. That is a very good idea! Highlighting for instance other Post title blocks in the layout would enforce the connection they have. Making it easier for the user to see the connection. As these are linked to each other because of the Query block. Changing one would automatically change the others.
Thanks for creating the issue!

@AshiqKiron
Copy link

I second @paaljoachim's comment. Your exploration would help users understand what's happening in real time.

@jameskoster
Copy link
Contributor Author

I'm not sure this actually needs design. All block instances can just have the is-selected state applied. The Toolbar being visible above the true-selected block is hopefully enough to denote focus.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Apr 7, 2021
@jameskoster jameskoster changed the title Site Editor: Highlight equivalent blocks in query Highlight equivalent blocks in query May 19, 2021
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Loop Affects the Query Loop Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants