Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use keyboard shortcut if toolbar is hidden #3035

Closed
ellatrix opened this issue Oct 17, 2017 · 2 comments
Closed

Unable to use keyboard shortcut if toolbar is hidden #3035

ellatrix opened this issue Oct 17, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@ellatrix
Copy link
Member

Issue Overview

After #2960, pressing the meta key (cmd/ctrl) still fails to focus the toolbar when it is hidden by typing.

Steps to Reproduce (for bugs)

  1. Select a block.
  2. Type inside the block so that the toolbar hides.
  3. Press cmd on Mac or ctrl elsewhere.
  4. Nothing happens.

Expected Behavior

I expected the toolbar to show and the first item the receive focus.

Related Issues and/or PRs
@ellatrix ellatrix added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 17, 2017
@ellatrix
Copy link
Member Author

@youknowriad That's probably a downside of doing this in the toolbar component, which removes the event listeners when it unmounts.

@youknowriad
Copy link
Contributor

This will be closed once #2998 land

@mtias mtias closed this as completed Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@youknowriad @mtias @ellatrix