Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image block caption to become an inner/child block #28920

Closed
paaljoachim opened this issue Feb 10, 2021 · 3 comments
Closed

Image block caption to become an inner/child block #28920

paaljoachim opened this issue Feb 10, 2021 · 3 comments
Labels
[Block] Image Affects the Image Block [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P Needs Design Feedback Needs general design feedback. [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Enhancement A suggestion for improvement.

Comments

@paaljoachim
Copy link
Contributor

paaljoachim commented Feb 10, 2021 •
edited
Loading

What problem does this address?

At the moment we are not able to align the Image block caption. Currently it looks like this when changing the Image size from Full to Medium.

Screen Shot 2021-02-10 at 13 36 21

It will need to be fixed.

What is your proposed solution?

One way to fix the problem and also give additional design options might be to change Image block captions into an inner/child block. So that one can for instance style the caption alignment similar to what @melchoyce Mel is suggesting here: Introduce explicit caption positioning #12997

Associated issues:

Image block selecting medium or thumbnail does not relocate caption - caption centered in relation to boundry box. (bug)
#17162

Important comment: #13684 (comment)

Missing text-align for image caption
#19975
@paaljoachim paaljoachim added [Block] Image Affects the Image Block [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Enhancement A suggestion for improvement. labels Feb 10, 2021
@paaljoachim paaljoachim mentioned this issue Feb 10, 2021
Open
22 tasks
@paaljoachim paaljoachim added [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P Needs Design Feedback Needs general design feedback. labels Feb 10, 2021
@paaljoachim paaljoachim mentioned this issue Feb 11, 2021
Merged
6 tasks
@paaljoachim paaljoachim mentioned this issue Feb 21, 2021
Closed
26 tasks
@mtias
Copy link
Member

mtias commented Feb 23, 2021

I think we should add caption positioning, but I don't think it should be turned into a child block.

@paaljoachim paaljoachim mentioned this issue May 14, 2021
Closed
7 tasks
@kellychoffman
Copy link
Contributor

@paaljoachim: Should we close this in favor of #12997 and the associated issues you mentioned? Or add further info re: child block.

@paaljoachim
Copy link
Contributor Author

Heya @kellychoffman

Sure why not..:)

@aaronrobertshaw aaronrobertshaw mentioned this issue Oct 26, 2022
Closed
@aaronrobertshaw aaronrobertshaw mentioned this issue Sep 26, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P Needs Design Feedback Needs general design feedback. [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtias @paaljoachim @kellychoffman