Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow previewing unsaved changes before saving template-parts in the site-editor #28778

Closed
aristath opened this issue Feb 5, 2021 · 3 comments
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@aristath
Copy link
Member

aristath commented Feb 5, 2021

Came up during a contributors day, from users testing FSE for the 1st time.

In the site-editor, try to make changes to the content, the header etc.
When it's time to save, hit the publish button and options appear saying "Are you ready to save:", followed by a list of things that changed with checkboxes.
If we don't want to save the header, then de-selecting the header template-part should change the preview to show the difference between new and old, allowing users to make an informed decision about whether they actually want to save it or not.

@aristath aristath added the [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") label Feb 5, 2021
@ntsekouras
Copy link
Contributor

Do you have something in mind for this design wise? For example with a small preview popover or in the editor undoing the changes?

Also it would be kind of tricky to handle the root changes preview, like Site Title, if it exists in a Template Part etc..

@aristath
Copy link
Member Author

aristath commented Feb 8, 2021

Users testing FSE were expecting the main view to simply change and show the previous (saved) version of the header when deselecting the header template-part from the save list. No popup etc... I don't know how easy that would be to accomplish though 🤔

@annezazu
Copy link
Contributor

Closing this out in favor of this current issue just to prevent any confusion: #28208

P.S. Thank you all so much for testing <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
None yet
Development

No branches or pull requests

3 participants