Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Menu item variations should show their corresponding icon #28578

Closed
jasmussen opened this issue Jan 29, 2021 · 0 comments · Fixed by #28626
Closed

Navigation Block: Menu item variations should show their corresponding icon #28578

jasmussen opened this issue Jan 29, 2021 · 0 comments · Fixed by #28626
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@jasmussen
Copy link
Contributor

When I manually insert a menu item, I choose from this screen:

Screenshot 2021-01-29 at 11 32 10

The "Page Link" is most commonly used (presumably), and is a variation on the Menu Item block. I would expect that icon to also be used for the block after having been inserted. But instead, the "Link" icon is shown:

Screenshot 2021-01-29 at 11 32 04

Can we show the icon that's correct for the variation chosen?

If this is technically not feasible, we should create a generic "Menu Item" icon instead, and show that.

Possibly related: #24814

@jasmussen jasmussen added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Jan 29, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
2 participants