Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parent/child selection behavior in the Quote block #28522

Closed
jasmussen opened this issue Jan 27, 2021 · 1 comment · Fixed by #28598
Closed

Improve parent/child selection behavior in the Quote block #28522

jasmussen opened this issue Jan 27, 2021 · 1 comment · Fixed by #28598
Assignees
Labels
[Block] Quote Affects the Quote Block [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jasmussen
Copy link
Contributor

The Quote block is about to receive nesting support (#25892). This benefits transformations, and solves basic issues like being able to have images inside a quote.

The nesting change also makes it slightly harder to select the parent block. This ticket suggests that we build a system that allows the quote block to always show its "select parent" button, even when an inner-block is selected. GIF showing how this could work:

gif

This behavior could benefit blocks where the parent and immediate child are highly tied together, such as Quote, Navigation, Social Links, perhaps even Gallery.

@jasmussen jasmussen added [Type] Enhancement A suggestion for improvement. [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Block] Quote Affects the Quote Block labels Jan 27, 2021
@mtias
Copy link
Member

mtias commented Jan 27, 2021

Thanks for sharing the gif. The blocks that would immediately benefit form this are Quote, Navigation, Buttons, Social Icons, and (soon) Gallery. It's not clear if other more generic nested blocks would benefit from it (Columns, Cover, Group). My initial impression is that they wouldn't.

To control the difference without introducing yet another prop to innerblocks I think we could look into whether explicit child blocks are allowed.

I like this ticket is focused on a single step. Later on we need to look at how "absorb toolbar" needs to expand to allow easier changes of a parents attributes, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Nested / Inner Blocks Anything related to the experience of nested/inner blocks inside a larger container, like Group or P [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants